upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

fix: don't trigger recursive SharesUpdatedListener when share is moved on create

Browse source 
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2026-04-10 20:15:24 +02:00
parent a77f8ca38c
commit b66abe553c
No known key found for this signature in database
GPG key ID: 42B69D8A64526EFB
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
apps/files_sharing/lib/Listener/SharesUpdatedListener.php
View file

@ -46,6 +46,7 @@ class SharesUpdatedListener implements IEventListener {
* The total amount of time we've spent so far processing updates
*/
private float $updatedTime = 0.0;
private bool $inUpdate = false;
public function __construct(
private readonly IManager $shareManager,
@ -60,6 +61,11 @@ class SharesUpdatedListener implements IEventListener {
}
public function handle(Event $event): void {
// prevent recursive updates
if ($this->inUpdate) {
return;
}
// don't trigger the on-setup checks if this handler triggers an fs setup
$oldState = $this->homeSetupListener->setDisabled(true);
@ -87,7 +93,9 @@ class SharesUpdatedListener implements IEventListener {
foreach ($this->shareManager->getUsersForShare($share) as $user) {
if ($share->getSharedBy() !== $user->getUID()) {
$this->markOrRun($user, function () use ($user, $share) {
$this->inUpdate = true;
$this->shareUpdater->updateForAddedShare($user, $share);
$this->inUpdate = false;
});
// Share target validation might have changed the target, restore it for the next user
$share->setTarget($shareTarget);