fix(settings): users settings cypress

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

apps/settings/src/views/Users.vue

@@ -34,7 +34,7 @@
 					</template>
 				</NcAppNavigationNew>
 
-				<NcAppNavigationList>
+				<NcAppNavigationList data-cy-users-settings-navigation-groups="system">
 					<NcAppNavigationItem id="everyone"
 						:exact="true"
 						:name="t('settings', 'Active accounts')"
@@ -99,7 +99,7 @@
 							{{ t('settings', 'Create group') }}
 						</NcActionText>
 						<NcActionInput :label="t('settings', 'Group name')"
-							data-cy-settings-new-group-name
+							data-cy-users-settings-new-group-name
 							:label-outside="false"
 							:disabled="loadingAddGroup"
 							:value.sync="newGroupName"
@@ -109,7 +109,7 @@
 					</template>
 				</NcAppNavigationCaption>
 
-				<NcAppNavigationList>
+				<NcAppNavigationList data-cy-users-settings-navigation-groups="custom">
 					<GroupListItem v-for="group in groupList"
 						:id="group.id"
 						:key="group.id"

cypress/e2e/settings/users_groups.cy.ts

@@ -39,7 +39,7 @@ describe('Settings: Create groups', () => {
 		// open the Create group menu
 		cy.get('button[aria-label="Create group"]').click()
 
-		cy.get('li[data-cy-settings-new-group-name]').within(() => {
+		cy.get('li[data-cy-users-settings-new-group-name]').within(() => {
 			// see that the group name is ""
 			cy.get('input').should('exist').and('have.value', '')
 			// set the group name to foo
@@ -54,7 +54,7 @@ describe('Settings: Create groups', () => {
 		handlePasswordConfirmation(admin.password)
 
 		// see that the created group is in the list
-		cy.get('ul.app-navigation-list').within(() => {
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
 			// see that the list of groups contains the group foo
 			cy.contains(groupName).should('exist')
 		})
@@ -76,8 +76,8 @@ describe('Settings: Assign user to a group', { testIsolation: false }, () => {
 	})
 
 	it('see that the group is in the list', () => {
-		cy.get('ul.app-navigation-list').contains('li', groupName).should('exist')
-		cy.get('ul.app-navigation-list').contains('li', groupName).within(() => {
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').contains('li', groupName).should('exist')
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').contains('li', groupName).within(() => {
 			cy.get('.counter-bubble__counter')
 				.should('not.exist') // is hidden when 0
 		})
@@ -118,7 +118,7 @@ describe('Settings: Assign user to a group', { testIsolation: false }, () => {
 
 	it('see the group was successfully assigned', () => {
 		// see a new memeber
-		cy.get('ul.app-navigation-list')
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]')
 			.contains('li', groupName)
 			.find('.counter-bubble__counter')
 			.should('contain', '1')
@@ -142,7 +142,7 @@ describe('Settings: Delete an empty group', { testIsolation: false }, () => {
 	})
 
 	it('see that the group is in the list', () => {
-		cy.get('ul.app-navigation-list').within(() => {
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
 			// see that the list of groups contains the group foo
 			cy.contains(groupName).should('exist').scrollIntoView()
 			// open the actions menu for the group
@@ -163,7 +163,7 @@ describe('Settings: Delete an empty group', { testIsolation: false }, () => {
 	})
 
 	it('deleted group is not shown anymore', () => {
-		cy.get('ul.app-navigation-list').within(() => {
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
 			// see that the list of groups does not contain the group
 			cy.contains(groupName).should('not.exist')
 		})
@@ -192,12 +192,12 @@ describe('Settings: Delete a non empty group', () => {
 
 	it('see that the group is in the list', () => {
 		// see that the list of groups contains the group
-		cy.get('ul.app-navigation-list').contains('li', groupName).should('exist').scrollIntoView()
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').contains('li', groupName).should('exist').scrollIntoView()
 	})
 
 	it('can delete the group', () => {
 		// open the menu
-		cy.get('ul.app-navigation-list')
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]')
 			.contains('li', groupName)
 			.find('button.action-item__menutoggle')
 			.click({ force: true })
@@ -212,7 +212,7 @@ describe('Settings: Delete a non empty group', () => {
 	})
 
 	it('deleted group is not shown anymore', () => {
-		cy.get('ul.app-navigation-list').within(() => {
+		cy.get('ul[data-cy-users-settings-navigation-groups="custom"]').within(() => {
 			// see that the list of groups does not contain the group foo
 			cy.contains(groupName).should('not.exist')
 		})