upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54

fix(QueryBuilder): Use correct parameter name in addSelect method

Browse source 
Signed-off-by: provokateurin <kate@provokateurin.de>
This commit is contained in:
provokateurin 2026-02-17 08:34:43 +01:00
parent 542d492b74
commit b41569d80c
No known key found for this signature in database
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
build/psalm-baseline.xml
View file

@ -3395,9 +3395,6 @@
<NullableReturnStatement>
<code><![CDATA[$alias]]></code>
</NullableReturnStatement>
<ParamNameMismatch>
<code><![CDATA[$selects]]></code>
</ParamNameMismatch>
</file>
<file src="lib/private/DB/QueryBuilder/QuoteHelper.php">
<InvalidNullableReturnType>

12
lib/private/DB/QueryBuilder/QueryBuilder.php
View file

@ -524,18 +524,18 @@ class QueryBuilder implements IQueryBuilder {
* ->leftJoin('u', 'phonenumbers', 'u.id = p.user_id');
* </code>
*
* @param mixed ...$selects The selection expression.
* @param mixed ...$select The selection expression.
*
* @return $this This QueryBuilder instance.
*/
public function addSelect(...$selects) {
if (count($selects) === 1 && is_array($selects[0])) {
$selects = $selects[0];
public function addSelect(...$select) {
if (count($select) === 1 && is_array($select[0])) {
$select = $select[0];
}
$this->addOutputColumns($selects);
$this->addOutputColumns($select);
$this->queryBuilder->addSelect(
$this->helper->quoteColumnNames($selects)
$this->helper->quoteColumnNames($select)
);
return $this;