diff --git a/lib/private/TempManager.php b/lib/private/TempManager.php index f5801e5ab98..fa7f891ca92 100644 --- a/lib/private/TempManager.php +++ b/lib/private/TempManager.php @@ -50,13 +50,14 @@ class TempManager implements ITempManager { $path = $this->generateTemporaryPath($postFix); $old_umask = umask(0077); - $fp = fopen($path, 'x'); + $fp = @fopen($path, 'x'); umask($old_umask); if ($fp === false) { $this->log->warning( 'Can not create a temporary file in directory {dir}. Check it exists and has correct permissions', [ 'dir' => $this->tmpBaseDir, + 'error' => error_get_last(), ] ); return false; @@ -71,11 +72,12 @@ class TempManager implements ITempManager { public function getTemporaryFolder($postFix = ''): string|false { $path = $this->generateTemporaryPath($postFix) . '/'; - if (mkdir($path, 0700) === false) { + if (@mkdir($path, 0700) === false) { $this->log->warning( 'Can not create a temporary folder in directory {dir}. Check it exists and has correct permissions', [ 'dir' => $this->tmpBaseDir, + 'error' => error_get_last(), ] ); return false; diff --git a/tests/lib/TempManagerTest.php b/tests/lib/TempManagerTest.php index d9261e2385a..cae7e9f8dd5 100644 --- a/tests/lib/TempManagerTest.php +++ b/tests/lib/TempManagerTest.php @@ -36,12 +36,7 @@ class TempManagerTest extends \Test\TestCase { parent::tearDown(); } - /** - * @param ?LoggerInterface $logger - * @param ?IConfig $config - * @return TempManager - */ - protected function getManager($logger = null, $config = null) { + protected function getManager(?LoggerInterface $logger = null, ?IConfig $config = null): TempManager { if (!$logger) { $logger = $this->createMock(LoggerInterface::class); }