From 6afe3e42f3601f4be65724c6c06951f1a4726fed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Wed, 6 Jun 2018 12:20:44 +0200
Subject: [PATCH 1/2] Add visual indicator for setup checks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 settings/css/settings.scss                    | 28 ++++++++++++++++---
 settings/js/admin.js                          |  9 ++++--
 .../templates/settings/admin/overview.php     | 21 +++++++++-----
 3 files changed, 44 insertions(+), 14 deletions(-)

diff --git a/settings/css/settings.scss b/settings/css/settings.scss
index 6adac7704cd..3062b9f51f3 100644
--- a/settings/css/settings.scss
+++ b/settings/css/settings.scss
@@ -1038,10 +1038,29 @@ table.grid td.date {
 	margin-top: 20px;
 }
 
-#security-warning-state span {
-	padding-left: 25px;
-	background-position: 5px center;
-	margin-left: -5px;
+#security-warning-state-ok,
+#security-warning-state-failure,
+#security-warning-state-loading {
+	span {
+		vertical-align: middle;
+
+		&.message {
+			padding: 12px;
+		}
+		&.icon {
+			width: 32px;
+			height: 32px;
+			background-position: center center;
+			display: inline-block;
+			border-radius: 50%;
+		}
+		&.icon-checkmark-white {
+			background-color: $color-success;
+		}
+		&.icon-close-white {
+			background-color: $color-error;
+		}
+	}
 }
 
 #shareAPI {
@@ -1204,6 +1223,7 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
 			list-style: circle;
 		}
 	}
+
 	.loading {
 		height: 50px;
 		background-position: left center;
diff --git a/settings/js/admin.js b/settings/js/admin.js
index 650bc84930c..0ebe1ebb23a 100644
--- a/settings/js/admin.js
+++ b/settings/js/admin.js
@@ -256,7 +256,7 @@ $(document).ready(function(){
 	).then(function(check1, check2, check3, check4, check5, check6) {
 		var messages = [].concat(check1, check2, check3, check4, check5, check6);
 		var $el = $('#postsetupchecks');
-		$el.find('.loading').addClass('hidden');
+		$('#security-warning-state-loading').addClass('hidden');
 
 		var hasMessages = false;
 		var $errorsEl = $el.find('.errors');
@@ -291,11 +291,14 @@ $(document).ready(function(){
 		}
 
 		if (hasMessages) {
-			$el.find('.hint').removeClass('hidden');
+			$('#postsetupchecks-hint').removeClass('hidden');
+			$('#security-warning-state-failure').removeClass('hidden');
 		} else {
 			var securityWarning = $('#security-warning');
 			if (securityWarning.children('ul').children().length === 0) {
-				$('#security-warning-state').find('span').removeClass('hidden');
+				$('#security-warning-state-ok').removeClass('hidden');
+			} else {
+				$('#security-warning-state-failure').removeClass('hidden');
 			}
 		}
 	});
diff --git a/settings/templates/settings/admin/overview.php b/settings/templates/settings/admin/overview.php
index 2bddd1f9c3e..dd253b82643 100644
--- a/settings/templates/settings/admin/overview.php
+++ b/settings/templates/settings/admin/overview.php
@@ -151,18 +151,25 @@
 			<?php endif; ?>
 	</ul>
 
+	<div id="security-warning-state-ok" class="hidden">
+		<span class="icon icon-checkmark-white"></span><span class="message"><?php p($l->t('All checks passed.'));?></span>
+	</div>
+	<div id="security-warning-state-failure" class="hidden">
+		<span class="icon icon-close-white"></span><span class="message"><?php p($l->t('Some checks have failed.'));?></span>
+	</div>
+	<div id="security-warning-state-loading">
+		<span class="icon loading"></span><span class="message"><?php p($l->t('Checking for system and security issues.'));?></span>
+	</div>
+
 	<div id="postsetupchecks" data-check-wellknown="<?php if($_['checkForWorkingWellKnownSetup']) { p('true'); } else { p('false'); } ?>">
-		<div class="loading"></div>
 		<ul class="errors hidden"></ul>
 		<ul class="warnings hidden"></ul>
 		<ul class="info hidden"></ul>
-		<p class="hint hidden">
-			<?php print_unescaped($l->t('Please double check the <a target="_blank" rel="noreferrer noopener" href="%s">installation guides ↗</a>, and check for any errors or warnings in the <a href="%s">log</a>.', [link_to_docs('admin-install'), \OC::$server->getURLGenerator()->linkToRoute('settings.AdminSettings.index', ['section' => 'logging'])] )); ?>
-		</p>
-	</div>
-	<div id="security-warning-state">
-		<span class="hidden icon-checkmark"><?php p($l->t('All checks passed.'));?></span>
 	</div>
+	<p id="postsetupchecks-hint" class="hidden">
+		<?php print_unescaped($l->t('Please double check the <a target="_blank" rel="noreferrer noopener" href="%s">installation guides ↗</a>, and check for any errors or warnings in the <a href="%s">log</a>.', [link_to_docs('admin-install'), \OC::$server->getURLGenerator()->linkToRoute('settings.AdminSettings.index', ['section' => 'logging'])] )); ?>
+	</p>
+
 </div>
 
 <div class="section">

From 5a20ac7df2e3e6ca4c7f43b66afd87c7c6493c5a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Wed, 6 Jun 2018 13:28:50 +0200
Subject: [PATCH 2/2] Add warning state to setup checks
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 settings/css/settings.scss                     | 4 ++++
 settings/js/admin.js                           | 6 +++++-
 settings/templates/settings/admin/overview.php | 5 ++++-
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/settings/css/settings.scss b/settings/css/settings.scss
index 3062b9f51f3..3b6befc4386 100644
--- a/settings/css/settings.scss
+++ b/settings/css/settings.scss
@@ -1039,6 +1039,7 @@ table.grid td.date {
 }
 
 #security-warning-state-ok,
+#security-warning-state-warning,
 #security-warning-state-failure,
 #security-warning-state-loading {
 	span {
@@ -1057,6 +1058,9 @@ table.grid td.date {
 		&.icon-checkmark-white {
 			background-color: $color-success;
 		}
+		&.icon-error-white {
+			background-color: $color-warning;
+		}
 		&.icon-close-white {
 			background-color: $color-error;
 		}
diff --git a/settings/js/admin.js b/settings/js/admin.js
index 0ebe1ebb23a..61c40e789ba 100644
--- a/settings/js/admin.js
+++ b/settings/js/admin.js
@@ -292,7 +292,11 @@ $(document).ready(function(){
 
 		if (hasMessages) {
 			$('#postsetupchecks-hint').removeClass('hidden');
-			$('#security-warning-state-failure').removeClass('hidden');
+			if ($errorsEl.find('li').length > 0) {
+				$('#security-warning-state-failure').removeClass('hidden');
+			} else {
+				$('#security-warning-state-warning').removeClass('hidden');
+			}
 		} else {
 			var securityWarning = $('#security-warning');
 			if (securityWarning.children('ul').children().length === 0) {
diff --git a/settings/templates/settings/admin/overview.php b/settings/templates/settings/admin/overview.php
index dd253b82643..08aee8b5b76 100644
--- a/settings/templates/settings/admin/overview.php
+++ b/settings/templates/settings/admin/overview.php
@@ -155,7 +155,10 @@
 		<span class="icon icon-checkmark-white"></span><span class="message"><?php p($l->t('All checks passed.'));?></span>
 	</div>
 	<div id="security-warning-state-failure" class="hidden">
-		<span class="icon icon-close-white"></span><span class="message"><?php p($l->t('Some checks have failed.'));?></span>
+		<span class="icon icon-close-white"></span><span class="message"><?php p($l->t('There are some errors regarding your setup.'));?></span>
+	</div>
+	<div id="security-warning-state-warning" class="hidden">
+		<span class="icon icon-error-white"></span><span class="message"><?php p($l->t('There are some warnings regarding your setup.'));?></span>
 	</div>
 	<div id="security-warning-state-loading">
 		<span class="icon loading"></span><span class="message"><?php p($l->t('Checking for system and security issues.'));?></span>