upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-22 14:50:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 53

Cache fetched apps in update check

Browse source 
The code tried to find the apps with updates and thus was called for every available app. This caused to get the full appstore content as often as apps are available. The appstore request itself was cached nevertheless in an appdata dir, but with an object storage this is still a lot of round trips to read this cached result. Thus the instantiated list is now cached in a static variable (because it's a static method call).

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This commit is contained in:
Morris Jobke 2017-11-23 15:04:51 +01:00
parent 3a6d16e6d4
commit a97a290fd5
No known key found for this signature in database
GPG key ID: FE03C3A163FEDE68
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/private/Installer.php
View file

@ -395,7 +395,11 @@ class Installer {
return false;
}
$apps = $appFetcher->get();
static $apps = null;
if ($apps === null) {
$apps = $appFetcher->get();
}
foreach($apps as $app) {
if($app['id'] === $appId) {
$currentVersion = OC_App::getAppVersion($appId);