Merge pull request #56042 from nextcloud/fix/55598

fix(files_external): check for changes when saving settings
2026-06-04 14:24:59 -04:00 · 2025-11-11 15:21:39 +00:00 · 2025-11-11 15:21:39 +00:00 · a459f56184
commit a459f56184
parent db9644eea2 f71d7458d3
3 changed files with 11 additions and 6 deletions
--- a/apps/files_external/src/settings.js
+++ b/apps/files_external/src/settings.js
@ -565,6 +565,8 @@ MountOptionsDropdown.prototype = {
 		this.setOptions(mountOptions, visibleOptions, storage)

 		this.$el.appendTo($container)
+
+		this._initialOptions = JSON.stringify(this.getOptions())
 		MountOptionsDropdown._last = this

 		this.$el.trigger('show')
@ -1472,11 +1474,14 @@ MountConfigListView.prototype = _.extend({
 		})

 		dropDown.$el.on('hide', function() {
-			const mountOptions = dropDown.getOptions()
+			const newOptions = dropDown.getOptions()
+			const newOptionsStr = JSON.stringify(newOptions)
 			$('body').off('mouseup.mountOptionsDropdown')
-			$tr.find('input.mountOptions').val(JSON.stringify(mountOptions))
 			$tr.find('td.mountOptionsToggle>.icon-more').attr('aria-expanded', 'false')
-			self.saveStorageConfig($tr)
+			if (dropDown._initialOptions !== newOptionsStr) {
+				$tr.find('input.mountOptions').val(newOptionsStr)
+				self.saveStorageConfig($tr)
+			}
 		})
 	},
 }, OC.Backbone.Events)
--- a/dist/files_external-settings.js
+++ b/dist/files_external-settings.js
--- a/dist/files_external-settings.js.map
+++ b/dist/files_external-settings.js.map