upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-11 09:42:09 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 57

fix: log request port instead since it's more relevant to the admin

Browse source 
Signed-off-by: Josh <josh.t.richards@gmail.com>
This commit is contained in:
Josh 2025-01-30 19:31:27 -05:00 committed by GitHub
parent e07c89d0e2
commit a1be491c27
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/private/Http/Client/DnsPinMiddleware.php
View file

@ -110,15 +110,15 @@ class DnsPinMiddleware {
}
$hostName = (string)$request->getUri()->getHost();
$port = $request->getUri()->getPort();
$requestPort = $request->getUri()->getPort();
$ports = [
'80',
'443',
];
if ($port !== null) {
$ports[] = (string)$port;
if ($requestPort !== null) {
$ports[] = (string)$requestPort;
}
$targetIps = $this->dnsResolve(idn_to_utf8($hostName), 0);
@ -135,7 +135,8 @@ class DnsPinMiddleware {
foreach ($targetIps as $ip) {
if ($this->ipAddressClassifier->isLocalAddress($ip)) {
// TODO: continue with all non-local IPs?
throw new LocalServerException('Host "' . $ip . '" (' . $hostName . ') violates local access rules');
// log requestPort because that's more relevant to the admin
throw new LocalServerException('Host "' . $ip . '" (' . $hostName . ':' . $requestPort . ') violates local access rules');
}
$curlResolves["$hostName:$port"][] = $ip;
}