chore: Remove deprecated OC.appSettings

Was deprecated since NC17 and scheduled for removal on NC18.
No apps use it and neither do core.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This commit is contained in:
Ferdinand Thiessen 2023-05-20 15:28:23 +02:00
parent 428366cc7c
commit a08b098476
8 changed files with 6 additions and 153 deletions

View file

@ -1,97 +0,0 @@
/**
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
*
* @author Christoph Wurst <christoph@winzerhof-wurst.at>
* @author John Molakvoæ <skjnldsv@protonmail.com>
*
* @license AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
/* eslint-disable */
import $ from 'jquery'
import { filePath } from './routing.js'
import { generateFilePath } from "@nextcloud/router"
/**
* Opens a popup with the setting for an app.
* @param {string} appid The ID of the app e.g. 'calendar', 'contacts' or 'files'.
* @param {boolean|string} loadJS If true 'js/settings.js' is loaded. If it's a string
* it will attempt to load a script by that name in the 'js' directory.
* @param {boolean} [cache] If true the javascript file won't be forced refreshed. Defaults to true.
* @param {string} [scriptName] The name of the PHP file to load. Defaults to 'settings.php' in
* the root of the app directory hierarchy.
*
* @deprecated 17.0.0 this method is unused and will be removed with Nextcloud 18
*/
export const appSettings = args => {
console.warn('OC.appSettings is deprecated and will be removed with Nextcloud 18')
if (typeof args === 'undefined' || typeof args.appid === 'undefined') {
throw {
name: 'MissingParameter',
message: 'The parameter appid is missing'
}
}
var props = { scriptName: 'settings.php', cache: true }
$.extend(props, args)
var settings = $('#appsettings')
if (settings.length === 0) {
throw {
name: 'MissingDOMElement',
message: 'There has be be an element with id "appsettings" for the popup to show.'
}
}
var popup = $('#appsettings_popup')
if (popup.length === 0) {
$('body').prepend('<div class="popup hidden" id="appsettings_popup"></div>')
popup = $('#appsettings_popup')
popup.addClass(settings.hasClass('topright') ? 'topright' : 'bottomleft')
}
if (popup.is(':visible')) {
popup.hide().remove()
} else {
const arrowclass = settings.hasClass('topright') ? 'up' : 'left'
$.get(generateFilePath(props.appid, '', props.scriptName), function(data) {
popup.html(data).ready(function() {
popup.prepend('<span class="arrow ' + arrowclass + '"></span><h2>' + t('core', 'Settings') + '</h2><a class="close"></a>').show()
popup.find('.close').bind('click', function() {
popup.remove()
})
if (typeof props.loadJS !== 'undefined') {
var scriptname
if (props.loadJS === true) {
scriptname = 'settings.js'
} else if (typeof props.loadJS === 'string') {
scriptname = props.loadJS
} else {
throw {
name: 'InvalidParameter',
message: 'The "loadJS" parameter must be either boolean or a string.'
}
}
if (props.cache) {
$.ajaxSetup({ cache: true })
}
$.getScript(generateFilePath(props.appid, 'js', scriptname))
.fail(function(jqxhr, settings, e) {
throw e
})
}
}).show()
}, 'html')
}
}

View file

@ -31,7 +31,6 @@ import {
registerXHRForErrorProcessing,
} from './xhr-error.js'
import { AppConfig, appConfig } from './appconfig.js'
import { appSettings } from './appsettings.js'
import appswebroots from './appswebroots.js'
import Backbone from './backbone.js'
import {
@ -142,7 +141,6 @@ export default {
addStyle,
AppConfig,
appConfig,
appSettings,
appswebroots,
Backbone,
ContactsMenu,

4
dist/core-login.js vendored

File diff suppressed because one or more lines are too long

View file

@ -167,30 +167,6 @@
*
*/
/**
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
*
* @author Christoph Wurst <christoph@winzerhof-wurst.at>
* @author John Molakvoæ <skjnldsv@protonmail.com>
* @author rakekniven <mark.ziegler@rakekniven.de>
*
* @license AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
/**
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
* @copyright Copyright (c) 2019 Gary Kim <gary@garykim.dev>

File diff suppressed because one or more lines are too long

4
dist/core-main.js vendored

File diff suppressed because one or more lines are too long

View file

@ -313,30 +313,6 @@
*
*/
/**
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
*
* @author Christoph Wurst <christoph@winzerhof-wurst.at>
* @author John Molakvoæ <skjnldsv@protonmail.com>
* @author rakekniven <mark.ziegler@rakekniven.de>
*
* @license AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
/**
* @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
* @copyright Copyright (c) 2019 Gary Kim <gary@garykim.dev>

File diff suppressed because one or more lines are too long