From 97633c5bf57ff5d394a429415071a785cadfd2c5 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Fri, 8 May 2026 18:12:13 +0200 Subject: [PATCH] perf: remove unneeded sort when listing federated shares Signed-off-by: Robin Appelman --- .../lib/FederatedShareProvider.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/federatedfilesharing/lib/FederatedShareProvider.php b/apps/federatedfilesharing/lib/FederatedShareProvider.php index f32e32b3148..57a4300b461 100644 --- a/apps/federatedfilesharing/lib/FederatedShareProvider.php +++ b/apps/federatedfilesharing/lib/FederatedShareProvider.php @@ -425,8 +425,7 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl $qb->select('*') ->from('share') ->where($qb->expr()->eq('parent', $qb->createNamedParameter($parent->getId()))) - ->andWhere($qb->expr()->in('share_type', $qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY))) - ->orderBy('id'); + ->andWhere($qb->expr()->in('share_type', $qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY))); $cursor = $qb->executeQuery(); while ($data = $cursor->fetch()) { @@ -558,8 +557,6 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl $qb->andWhere($qb->expr()->eq('f.parent', $qb->createNamedParameter($node->getId()))); - $qb->orderBy('id'); - $cursor = $qb->executeQuery(); $shares = []; while ($data = $cursor->fetch()) { @@ -614,7 +611,9 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl } $qb->setFirstResult($offset); - $qb->orderBy('id'); + if ($offset !== 0 || $limit !== -1) { + $qb->orderBy('id'); + } $cursor = $qb->executeQuery(); $shares = []; @@ -691,8 +690,9 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl $qb->select('*') ->from('share'); - // Order by id - $qb->orderBy('id'); + if ($offset !== 0 || $limit !== -1) { + $qb->orderBy('id'); + } // Set limit and offset if ($limit !== -1) {