upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

Merge pull request #58526 from nextcloud/fix/icon-ratio

Browse source 
fix(theming): Fix favicon and touchicon ratios
This commit is contained in:
Sebastian Krupinski 2026-03-02 09:04:57 -05:00 committed by GitHub
commit 95e3dba34c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
apps/theming/lib/IconBuilder.php
View file

@ -144,9 +144,8 @@ class IconBuilder {
$y = $tmp->getImageHeight();
$tmp->destroy();
// set resolution for proper scaling
$resX = (int)(72 * $size / $x);
$resY = (int)(72 * $size / $y);
$appIconFile->setResolution($resX, $resY);
$res = (int)(72 * $size / max($x, $y));
$appIconFile->setResolution($res, $res);
$appIconFile->readImageBlob($svg);
} else {
// handle non-SVG images

6
apps/theming/tests/IconBuilderTest.php
View file

@ -297,11 +297,9 @@ class IconBuilderTest extends TestCase {
$x = $tmp->getImageWidth();
$y = $tmp->getImageHeight();
$tmp->destroy();
// set resolution for proper scaling
$resX = (int)(72 * $size / $x);
$resY = (int)(72 * $size / $y);
$res = (int)(72 * $size / max($x, $y));
$appIconFile->setBackgroundColor(new \ImagickPixel('transparent'));
$appIconFile->setResolution($resX, $resY);
$appIconFile->setResolution($res, $res);
$appIconFile->readImageBlob($svgContent);
} else {
$appIconFile->readImage($filePath);