From 91f3b6b4ee60e0f8bb6e21f92d5bc52e4cebe657 Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Wed, 1 Oct 2025 16:03:40 +0200 Subject: [PATCH] chore: adjust code to new codestyle Signed-off-by: Ferdinand Thiessen --- __mocks__/@nextcloud/auth.ts | 7 +- __mocks__/@nextcloud/capabilities.ts | 5 +- __mocks__/@nextcloud/initial-state.ts | 2 +- __mocks__/webdav.ts | 7 +- __tests__/FileSystemAPIUtils.ts | 15 +- .../inlineUnreadCommentsAction.spec.ts | 16 +- .../src/actions/inlineUnreadCommentsAction.ts | 12 +- apps/comments/src/comments-activity-tab.ts | 4 +- apps/comments/src/comments-app.js | 3 +- apps/comments/src/comments-tab.js | 1 - apps/comments/src/components/Comment.vue | 44 +- apps/comments/src/init.ts | 3 +- apps/comments/src/mixins/CommentMixin.js | 12 +- apps/comments/src/mixins/CommentView.ts | 12 +- .../comments/src/services/CommentsInstance.js | 8 +- apps/comments/src/services/DavClient.js | 7 +- apps/comments/src/services/EditComment.js | 4 +- apps/comments/src/services/GetComments.ts | 39 +- apps/comments/src/services/NewComment.js | 2 +- apps/comments/src/services/ReadComments.ts | 8 +- apps/comments/src/utils/cancelableRequest.js | 4 +- apps/comments/src/utils/davUtils.js | 5 +- .../src/views/ActivityCommentAction.vue | 15 +- .../src/views/ActivityCommentEntry.vue | 8 +- apps/comments/src/views/Comments.vue | 35 +- apps/dashboard/src/DashboardApp.vue | 81 +- .../src/components/ApiDashboardWidget.vue | 18 +- .../src/components/ApiDashboardWidgetItem.vue | 14 +- apps/dashboard/src/logger.ts | 11 + apps/dashboard/src/main.js | 2 - apps/dav/src/components/AbsenceForm.vue | 64 +- apps/dav/src/components/AvailabilityForm.vue | 31 +- .../src/components/ExampleContactSettings.vue | 44 +- .../ExampleContentDownloadButton.vue | 6 +- .../src/components/ExampleEventSettings.vue | 45 +- apps/dav/src/dav/client.js | 6 +- apps/dav/src/service/CalendarService.js | 13 +- apps/dav/src/service/ExampleEventService.js | 2 +- apps/dav/src/service/PreferenceService.js | 10 +- apps/dav/src/settings-example-content.js | 7 +- .../dav/src/settings-personal-availability.js | 5 +- apps/dav/src/settings.js | 7 +- apps/dav/src/views/Availability.vue | 10 +- apps/dav/src/views/CalDavSettings.spec.js | 24 +- apps/dav/src/views/CalDavSettings.vue | 35 +- .../views/ExampleContentSettingsSection.vue | 7 +- apps/encryption/js/encryption.js | 27 +- apps/encryption/js/settings-admin.js | 105 +- apps/encryption/js/settings-personal.js | 87 +- .../src/components/AdminSettings.vue | 48 +- .../src/components/PersonalSettings.vue | 35 +- .../src/components/RemoteShareDialog.vue | 6 +- apps/federatedfilesharing/src/external.js | 4 +- apps/federatedfilesharing/src/main-admin.js | 10 +- .../federatedfilesharing/src/main-personal.js | 4 +- .../src/services/dialogService.spec.ts | 2 +- .../src/services/dialogService.ts | 4 +- .../src/services/logger.ts | 1 + apps/federation/js/settings-admin.js | 185 ++- apps/files/src/FilesApp.vue | 8 +- apps/files/src/actions/convertAction.ts | 39 +- apps/files/src/actions/convertUtils.ts | 57 +- apps/files/src/actions/deleteAction.spec.ts | 16 +- apps/files/src/actions/deleteAction.ts | 18 +- apps/files/src/actions/deleteUtils.ts | 82 +- apps/files/src/actions/downloadAction.spec.ts | 8 +- apps/files/src/actions/downloadAction.ts | 28 +- apps/files/src/actions/favoriteAction.spec.ts | 34 +- apps/files/src/actions/favoriteAction.ts | 34 +- apps/files/src/actions/moveOrCopyAction.ts | 82 +- .../src/actions/moveOrCopyActionUtils.ts | 29 +- .../src/actions/openFolderAction.spec.ts | 8 +- apps/files/src/actions/openFolderAction.ts | 6 +- .../src/actions/openInFilesAction.spec.ts | 9 +- apps/files/src/actions/openInFilesAction.ts | 4 +- .../src/actions/openLocallyAction.spec.ts | 11 +- apps/files/src/actions/openLocallyAction.ts | 23 +- apps/files/src/actions/renameAction.spec.ts | 12 +- apps/files/src/actions/renameAction.ts | 14 +- apps/files/src/actions/sidebarAction.spec.ts | 25 +- apps/files/src/actions/sidebarAction.ts | 6 +- .../src/actions/viewInFolderAction.spec.ts | 10 +- apps/files/src/actions/viewInFolderAction.ts | 5 +- apps/files/src/components/BreadCrumbs.vue | 32 +- .../src/components/CustomElementRender.vue | 6 + .../src/components/DragAndDropNotice.vue | 22 +- .../src/components/DragAndDropPreview.vue | 11 +- apps/files/src/components/FileEntry.vue | 58 +- .../components/FileEntry/CollectivesIcon.vue | 8 +- .../src/components/FileEntry/FavoriteIcon.vue | 6 +- .../components/FileEntry/FileEntryActions.vue | 70 +- .../FileEntry/FileEntryCheckbox.vue | 24 +- .../components/FileEntry/FileEntryName.vue | 35 +- .../components/FileEntry/FileEntryPreview.vue | 61 +- apps/files/src/components/FileEntryGrid.vue | 31 +- apps/files/src/components/FileEntryMixin.ts | 22 +- .../FileListFilter/FileListFilter.vue | 10 +- .../FileListFilter/FileListFilterModified.vue | 7 +- .../FileListFilter/FileListFilterType.vue | 10 +- apps/files/src/components/FileListFilters.vue | 14 +- ...{Setting.vue => FilesAppSettingsEntry.vue} | 4 +- apps/files/src/components/FilesListHeader.vue | 9 +- .../src/components/FilesListTableFooter.vue | 23 +- .../src/components/FilesListTableHeader.vue | 35 +- .../FilesListTableHeaderActions.vue | 69 +- .../components/FilesListTableHeaderButton.vue | 11 +- .../files/src/components/FilesListVirtual.vue | 66 +- .../src/components/FilesNavigationItem.vue | 26 +- .../src/components/FilesNavigationSearch.vue | 6 +- apps/files/src/components/LegacyView.vue | 6 +- apps/files/src/components/NavigationQuota.vue | 24 +- apps/files/src/components/NewNodeDialog.vue | 23 +- .../Settings/SettingsSanitizeFilenames.vue | 10 +- apps/files/src/components/SidebarTab.vue | 10 +- apps/files/src/components/TemplateFiller.vue | 18 +- .../TemplateFiller/TemplateCheckboxField.vue | 4 +- .../TemplateFiller/TemplateRichTextField.vue | 4 +- apps/files/src/components/TemplatePreview.vue | 21 +- .../components/TransferOwnershipDialogue.vue | 41 +- apps/files/src/components/VirtualList.vue | 42 +- .../src/composables/useFileListWidth.cy.ts | 1 - .../files/src/composables/useFileListWidth.ts | 1 + apps/files/src/composables/useHotKeys.spec.ts | 22 +- apps/files/src/composables/useHotKeys.ts | 7 +- .../src/composables/useNavigation.spec.ts | 33 +- apps/files/src/composables/useNavigation.ts | 8 +- .../src/composables/useRouteParameters.ts | 27 +- apps/files/src/eventbus.d.ts | 4 +- apps/files/src/filters/FilenameFilter.ts | 16 +- apps/files/src/filters/HiddenFilesFilter.ts | 7 +- apps/files/src/filters/ModifiedFilter.ts | 9 +- apps/files/src/filters/SearchFilter.ts | 2 - apps/files/src/filters/TypeFilter.ts | 133 +- apps/files/src/init.ts | 55 +- apps/files/src/main-settings-admin.ts | 1 - apps/files/src/main-settings-personal.ts | 1 - apps/files/src/main.ts | 8 +- apps/files/src/mixins/actionsMixin.ts | 5 +- apps/files/src/mixins/filesSorting.ts | 7 +- apps/files/src/models/Setting.js | 2 - apps/files/src/models/Tab.js | 3 - apps/files/src/newMenu/newFolder.ts | 33 +- apps/files/src/newMenu/newFromTemplate.ts | 16 +- apps/files/src/newMenu/newTemplatesFolder.ts | 21 +- apps/files/src/plugins/search/folderSearch.ts | 7 +- apps/files/src/reference-files.ts | 8 +- apps/files/src/router/router.ts | 6 +- apps/files/src/services/DropService.ts | 47 +- .../src/services/DropServiceUtils.spec.ts | 15 +- apps/files/src/services/DropServiceUtils.ts | 51 +- apps/files/src/services/Favorites.ts | 8 +- apps/files/src/services/Files.ts | 11 +- apps/files/src/services/FolderTree.ts | 59 +- apps/files/src/services/LivePhotos.ts | 6 +- apps/files/src/services/PersonalFiles.ts | 18 +- apps/files/src/services/PreviewService.ts | 1 + apps/files/src/services/Recent.ts | 16 +- apps/files/src/services/RouterService.ts | 6 +- apps/files/src/services/Search.spec.ts | 8 +- apps/files/src/services/Search.ts | 4 +- apps/files/src/services/Settings.js | 10 +- apps/files/src/services/Sidebar.js | 14 +- apps/files/src/services/Templates.js | 15 +- apps/files/src/services/WebDavSearch.ts | 4 +- apps/files/src/services/WebdavClient.ts | 8 +- apps/files/src/sidebar.ts | 7 +- apps/files/src/store/actionsmenu.ts | 4 +- apps/files/src/store/active.ts | 9 +- apps/files/src/store/dragging.ts | 4 +- apps/files/src/store/files.ts | 31 +- apps/files/src/store/filters.ts | 24 +- apps/files/src/store/index.ts | 5 +- apps/files/src/store/keyboard.ts | 5 +- apps/files/src/store/paths.spec.ts | 8 +- apps/files/src/store/paths.ts | 24 +- apps/files/src/store/renaming.ts | 6 +- apps/files/src/store/search.ts | 6 +- apps/files/src/store/selection.ts | 6 +- apps/files/src/store/uploader.ts | 13 +- apps/files/src/store/userconfig.ts | 8 +- apps/files/src/store/viewConfig.ts | 11 +- apps/files/src/types.ts | 20 +- apps/files/src/utils/actionUtils.ts | 11 +- apps/files/src/utils/davUtils.ts | 9 +- apps/files/src/utils/dragUtils.ts | 9 +- apps/files/src/utils/fileUtils.ts | 10 +- apps/files/src/utils/filenameValidity.ts | 23 +- apps/files/src/utils/hashUtils.ts | 5 +- apps/files/src/utils/newNodeDialog.ts | 6 +- apps/files/src/utils/permissions.ts | 1 + .../views/DialogConfirmFileExtension.cy.ts | 3 +- .../src/views/DialogConfirmFileExtension.vue | 19 +- .../src/views/FileReferencePickerElement.vue | 7 +- .../{Settings.vue => FilesAppSettings.vue} | 69 +- apps/files/src/views/FilesList.vue | 103 +- ...Navigation.cy.ts => FilesNavigation.cy.ts} | 34 +- .../{Navigation.vue => FilesNavigation.vue} | 35 +- .../views/{Sidebar.vue => FilesSidebar.vue} | 86 +- apps/files/src/views/ReferenceFileWidget.vue | 36 +- apps/files/src/views/SearchEmptyView.vue | 3 +- apps/files/src/views/SettingsAdmin.vue | 10 +- apps/files/src/views/TemplatePicker.vue | 37 +- apps/files/src/views/favorites.spec.ts | 35 +- apps/files/src/views/favorites.ts | 63 +- apps/files/src/views/files.ts | 5 +- apps/files/src/views/folderTree.ts | 91 +- apps/files/src/views/personal-files.ts | 5 +- apps/files/src/views/recent.ts | 8 +- apps/files/src/views/search.ts | 6 +- apps/files_external/js/oauth2.js | 135 +- apps/files_external/js/public_key.js | 67 +- .../actions/enterCredentialsAction.spec.ts | 10 +- .../src/actions/enterCredentialsAction.ts | 27 +- .../src/actions/inlineStorageCheckAction.ts | 24 +- .../src/actions/openInFilesAction.spec.ts | 14 +- .../src/actions/openInFilesAction.ts | 11 +- apps/files_external/src/init.ts | 13 +- .../src/services/externalStorage.ts | 39 +- apps/files_external/src/settings.js | 153 +- .../src/utils/credentialsUtils.ts | 8 +- .../src/utils/externalStorageUtils.spec.ts | 3 +- .../src/utils/externalStorageUtils.ts | 14 +- .../src/views/CredentialsDialog.vue | 17 +- .../src/actions/clearReminderAction.ts | 14 +- .../src/actions/reminderStatusAction.ts | 8 +- .../src/actions/setReminderCustomAction.ts | 7 +- .../src/actions/setReminderMenuAction.ts | 2 +- .../actions/setReminderSuggestionActions.ts | 19 +- .../src/components/SetCustomReminderModal.vue | 36 +- apps/files_reminders/src/init.ts | 10 +- .../src/services/customPicker.ts | 8 +- .../src/services/reminderService.ts | 19 +- apps/files_reminders/src/shared/utils.ts | 48 +- apps/files_sharing/src/additionalScripts.js | 1 - .../src/collaborationresourceshandler.js | 1 - .../src/components/FileListFilterAccount.vue | 28 +- .../src/components/NewFileRequestDialog.vue | 79 +- .../NewFileRequestDialogDatePassword.vue | 34 +- .../NewFileRequestDialogFinish.vue | 31 +- .../NewFileRequestDialogIntro.vue | 29 +- .../src/components/PersonalSettings.vue | 13 +- .../components/SelectShareFolderDialogue.vue | 14 +- .../src/components/ShareExpiryTime.vue | 11 +- .../src/components/SharingEntry.vue | 24 +- .../src/components/SharingEntryInherited.vue | 24 +- .../src/components/SharingEntryInternal.vue | 17 +- .../src/components/SharingEntryLink.vue | 129 +- .../SharingEntryQuickShareSelect.vue | 51 +- .../src/components/SharingEntrySimple.vue | 7 +- .../src/components/SharingInput.vue | 133 +- .../SidebarTabExternalAction.vue | 3 +- .../SidebarTabExternalActionLegacy.vue | 7 +- .../SidebarTabExternalSectionLegacy.vue | 6 +- .../files_actions/acceptShareAction.spec.ts | 22 +- .../src/files_actions/acceptShareAction.ts | 17 +- .../files_actions/openInFilesAction.spec.ts | 22 +- .../src/files_actions/openInFilesAction.ts | 4 +- .../files_actions/rejectShareAction.spec.ts | 26 +- .../src/files_actions/rejectShareAction.ts | 21 +- .../files_actions/restoreShareAction.spec.ts | 15 +- .../src/files_actions/restoreShareAction.ts | 15 +- .../src/files_actions/sharingStatusAction.ts | 37 +- .../src/files_filters/AccountFilter.ts | 10 +- .../src/files_headers/noteToRecipient.ts | 3 +- .../src/files_newMenu/newFileRequest.ts | 17 +- apps/files_sharing/src/files_sharing_tab.js | 12 +- .../src/files_views/publicFileDrop.ts | 4 +- .../src/files_views/publicFileShare.ts | 11 +- .../src/files_views/publicShare.ts | 7 +- .../src/files_views/shares.spec.ts | 24 +- apps/files_sharing/src/files_views/shares.ts | 14 +- apps/files_sharing/src/init-public.ts | 12 +- apps/files_sharing/src/init.ts | 20 +- .../src/lib/SharePermissionsToolBox.spec.js | 7 +- apps/files_sharing/src/mixins/ShareDetails.js | 3 +- .../files_sharing/src/mixins/ShareRequests.js | 20 +- apps/files_sharing/src/mixins/SharesMixin.js | 98 +- apps/files_sharing/src/models/Share.ts | 35 +- apps/files_sharing/src/personal-settings.js | 2 - .../src/public-nickname-handler.ts | 27 +- apps/files_sharing/src/router/index.ts | 5 +- .../src/services/ConfigService.ts | 97 +- .../src/services/ExternalLinkActions.js | 2 - .../src/services/ExternalShareActions.js | 6 +- .../src/services/GuestNameValidity.ts | 23 +- .../files_sharing/src/services/ShareSearch.js | 8 +- .../src/services/SharingService.spec.ts | 12 +- .../src/services/SharingService.ts | 69 +- .../files_sharing/src/services/TabSections.js | 2 - .../src/services/TokenService.ts | 7 +- apps/files_sharing/src/services/logger.ts | 1 + apps/files_sharing/src/sharing.d.ts | 2 +- .../src/utils/AccountIcon.spec.ts | 6 +- apps/files_sharing/src/utils/AccountIcon.ts | 12 +- .../src/utils/GeneratePassword.ts | 11 +- .../files_sharing/src/utils/NodeShareUtils.ts | 33 +- apps/files_sharing/src/utils/SharedWithMe.js | 6 +- .../src/views/FilesHeaderNoteToRecipient.vue | 6 +- .../views/FilesViewFileDropEmptyContent.vue | 19 +- .../src/views/SharingDetailsTab.vue | 279 ++-- .../src/views/SharingInherited.vue | 34 +- .../src/views/SharingLinkList.vue | 25 +- apps/files_sharing/src/views/SharingList.vue | 10 +- apps/files_sharing/src/views/SharingTab.vue | 92 +- .../src/files_actions/restoreAction.spec.ts | 15 +- .../src/files_actions/restoreAction.ts | 13 +- .../emptyTrashAction.spec.ts | 8 +- .../src/files_listActions/emptyTrashAction.ts | 14 +- .../src/files_views/columns.spec.ts | 5 +- .../files_trashbin/src/files_views/columns.ts | 7 +- .../src/files_views/trashbinView.spec.ts | 7 +- .../src/files_views/trashbinView.ts | 5 +- apps/files_trashbin/src/services/api.spec.ts | 8 +- apps/files_trashbin/src/services/api.ts | 3 +- apps/files_trashbin/src/services/trashbin.ts | 18 +- .../{Version.vue => VersionEntry.vue} | 73 +- .../src/components/VersionLabelDialog.vue | 16 +- .../src/components/VirtualScrolling.vue | 48 +- apps/files_versions/src/files_versions_tab.js | 10 +- apps/files_versions/src/utils/davClient.js | 10 +- apps/files_versions/src/utils/versions.ts | 43 +- apps/files_versions/src/views/VersionTab.vue | 44 +- apps/oauth2/src/App.vue | 38 +- apps/oauth2/src/components/OAuthItem.vue | 20 +- apps/oauth2/src/main.js | 2 +- apps/profile/src/main.ts | 5 +- apps/profile/src/services/ProfileSections.ts | 4 +- .../src/views/{Profile.vue => ProfileApp.vue} | 71 +- apps/settings/js/security_password.js | 96 +- apps/settings/js/settings.js | 79 +- apps/settings/js/usersettings.js | 42 +- apps/settings/src/admin.js | 2 +- apps/settings/src/app-types.ts | 28 +- apps/settings/src/components/AdminAI.vue | 86 +- .../src/components/AdminDelegating.vue | 8 +- .../AdminDelegation/GroupSelect.vue | 17 +- .../components/AdminSettingsSharingForm.vue | 77 +- .../src/components/AdminTwoFactor.vue | 59 +- .../AppAPI/DaemonSelectionDialog.vue | 15 +- .../AppAPI/DaemonSelectionEntry.vue | 16 +- .../components/AppAPI/DaemonSelectionList.vue | 22 +- apps/settings/src/components/AppList.vue | 90 +- .../src/components/AppList/AppDaemonBadge.vue | 4 +- .../src/components/AppList/AppItem.vue | 97 +- .../src/components/AppList/AppLevelBadge.vue | 6 +- .../src/components/AppList/AppScore.vue | 19 +- .../src/components/AppNavigationGroupList.vue | 38 +- .../components/AppStoreDiscover/AppLink.vue | 6 +- .../AppStoreDiscoverSection.vue | 25 +- .../components/AppStoreDiscover/AppType.vue | 11 +- .../AppStoreDiscover/CarouselType.vue | 23 +- .../components/AppStoreDiscover/PostType.vue | 33 +- .../AppStoreDiscover/ShowcaseType.vue | 14 +- .../AppStoreSidebar/AppDeployDaemonTab.vue | 12 +- .../AppStoreSidebar/AppDeployOptionsModal.vue | 83 +- .../AppStoreSidebar/AppDescriptionTab.vue | 8 +- .../AppStoreSidebar/AppDetailsTab.vue | 88 +- .../AppStoreSidebar/AppReleasesTab.vue | 8 +- apps/settings/src/components/AuthToken.vue | 107 +- .../settings/src/components/AuthTokenList.vue | 9 +- .../src/components/AuthTokenSection.vue | 5 +- .../src/components/AuthTokenSetup.vue | 25 +- .../src/components/AuthTokenSetupDialog.vue | 40 +- .../BasicSettings/BackgroundJob.vue | 43 +- .../BasicSettings/ProfileSettings.vue | 14 +- .../DeclarativeSection.vue | 55 +- .../Encryption/EncryptionSettings.vue | 25 +- .../Encryption/EncryptionWarningDialog.vue | 6 +- .../settings/src/components/GroupListItem.vue | 42 +- apps/settings/src/components/Markdown.vue | 7 +- .../src/components/PasswordSection.vue | 25 +- .../components/PersonalInfo/AvatarSection.vue | 61 +- .../PersonalInfo/BiographySection.vue | 5 +- .../PersonalInfo/BirthdaySection.vue | 17 +- .../PersonalInfo/BlueskySection.vue | 10 +- .../PersonalInfo/DetailsSection.vue | 5 +- .../PersonalInfo/DisplayNameSection.vue | 11 +- .../EmailSection/EmailSection.vue | 24 +- .../{Email.vue => EmailSectionEntry.vue} | 67 +- .../PersonalInfo/FediverseSection.vue | 8 +- .../PersonalInfo/FirstDayOfWeekSection.vue | 28 +- .../PersonalInfo/HeadlineSection.vue | 5 +- .../LanguageSection/LanguageSection.vue | 12 +- ...{Language.vue => LanguageSectionEntry.vue} | 20 +- .../LocaleSection/LocaleSection.vue | 12 +- .../{Locale.vue => LocaleSectionEntry.vue} | 13 +- .../PersonalInfo/LocationSection.vue | 5 +- .../PersonalInfo/OrganisationSection.vue | 5 +- .../components/PersonalInfo/PhoneSection.vue | 7 +- .../ProfileSection/EditProfileAnchorLink.vue | 6 +- .../ProfileSection/ProfileCheckbox.vue | 8 +- .../ProfileSection/ProfilePreviewCard.vue | 13 +- .../ProfileSection/ProfileSection.vue | 9 +- .../ProfileVisibilitySection.vue | 19 +- .../VisibilityDropdown.vue | 14 +- .../PersonalInfo/PronounsSection.vue | 3 +- .../components/PersonalInfo/RoleSection.vue | 5 +- .../PersonalInfo/TimezoneSection.vue | 6 +- .../PersonalInfo/TwitterSection.vue | 6 +- .../PersonalInfo/WebsiteSection.vue | 5 +- .../shared/AccountPropertySection.vue | 26 +- .../PersonalInfo/shared/FederationControl.vue | 20 +- .../PersonalInfo/shared/HeaderBar.vue | 14 +- .../components/SelectSharingPermissions.vue | 9 + .../SettingsPresets/PresetVisualisation.vue | 35 +- .../SettingsPresets/PresetsSelectionForm.vue | 51 +- .../SettingsSetupChecksList.vue | 3 +- .../SettingsSetupChecksListItem.vue | 5 +- .../src/components/SvgFilterMixin.vue | 2 + apps/settings/src/components/UserList.vue | 42 +- .../src/components/Users/NewUserDialog.vue | 69 +- .../src/components/Users/UserListFooter.vue | 24 +- .../src/components/Users/UserListHeader.vue | 48 +- .../settings/src/components/Users/UserRow.vue | 160 +- .../src/components/Users/UserRowActions.vue | 27 +- .../components/Users/UserSettingsDialog.vue | 66 +- .../src/components/Users/VirtualList.vue | 19 +- .../{AddDevice.vue => WebAuthnAddDevice.vue} | 40 +- .../{Device.vue => WebAuthnDevice.vue} | 6 +- .../{Section.vue => WebAuthnSection.vue} | 33 +- apps/settings/src/composables/useAppIcon.ts | 2 +- .../src/composables/useGetLocalizedValue.ts | 14 +- .../src/composables/useGroupsNavigation.ts | 20 +- .../src/constants/AppDiscoverTypes.ts | 2 +- .../settings/src/constants/GroupManagement.ts | 2 +- apps/settings/src/main-admin-ai.js | 2 - .../settings/src/main-admin-basic-settings.js | 8 +- apps/settings/src/main-admin-security.js | 6 +- .../src/main-admin-settings-presets.ts | 9 +- .../src/main-apps-users-management.ts | 13 +- .../src/main-declarative-settings-forms.ts | 44 +- apps/settings/src/main-personal-info.js | 5 +- apps/settings/src/main-personal-password.js | 6 +- apps/settings/src/main-personal-security.js | 4 +- apps/settings/src/main-personal-webauth.js | 5 +- apps/settings/src/mixins/AppManagement.js | 32 +- apps/settings/src/mixins/UserRowMixin.js | 12 +- apps/settings/src/router/index.ts | 2 +- apps/settings/src/router/routes.ts | 1 + .../src/service/PersonalInfo/EmailService.js | 17 +- .../PersonalInfo/PersonalInfoService.js | 9 +- apps/settings/src/service/ProfileService.js | 9 +- .../src/service/WebAuthnRegistrationSerice.ts | 6 +- apps/settings/src/service/groups.ts | 52 +- .../src/service/rebuild-navigation.js | 2 +- apps/settings/src/store/admin-security.js | 2 +- apps/settings/src/store/api.js | 6 +- apps/settings/src/store/app-api-store.ts | 36 +- apps/settings/src/store/apps-store.ts | 8 +- apps/settings/src/store/apps.js | 58 +- apps/settings/src/store/authtoken.ts | 20 +- apps/settings/src/store/index.js | 24 +- apps/settings/src/store/oc.js | 4 +- apps/settings/src/store/users.js | 185 ++- .../src/utils/appDiscoverParser.spec.ts | 4 +- apps/settings/src/utils/appDiscoverParser.ts | 5 +- apps/settings/src/utils/handlers.ts | 2 +- apps/settings/src/utils/userUtils.ts | 3 +- apps/settings/src/utils/validate.js | 3 +- .../src/views/AdminSettingsSetupChecks.vue | 10 +- .../src/views/AdminSettingsSharing.vue | 6 +- apps/settings/src/views/AppStore.vue | 12 +- .../settings/src/views/AppStoreNavigation.vue | 40 +- apps/settings/src/views/AppStoreSidebar.vue | 27 +- apps/settings/src/views/SettingsPresets.vue | 25 +- apps/settings/src/views/UserManagement.vue | 6 +- .../src/views/UserManagementNavigation.vue | 47 +- .../src/components/AdminSettings.vue | 23 +- apps/sharebymail/src/logger.ts | 11 + apps/systemtags/src/admin.ts | 1 - .../src/components/SystemTagForm.vue | 74 +- .../src/components/SystemTagPicker.vue | 107 +- apps/systemtags/src/components/SystemTags.vue | 72 +- .../components/SystemTagsCreationControl.vue | 17 +- apps/systemtags/src/event-bus.d.ts | 3 +- .../bulkSystemTagsAction.spec.ts | 7 +- .../src/files_actions/bulkSystemTagsAction.ts | 21 +- .../inlineSystemTagsAction.spec.ts | 57 +- .../files_actions/inlineSystemTagsAction.ts | 57 +- .../files_actions/openInFilesAction.spec.ts | 7 +- .../src/files_actions/openInFilesAction.ts | 8 +- .../src/files_views/systemtagsView.ts | 7 +- apps/systemtags/src/init.ts | 11 +- .../src/services/HotKeysService.spec.ts | 10 +- .../systemtags/src/services/HotKeysService.ts | 5 +- apps/systemtags/src/services/api.ts | 67 +- apps/systemtags/src/services/davClient.ts | 10 +- apps/systemtags/src/services/files.ts | 27 +- apps/systemtags/src/services/systemtags.ts | 31 +- apps/systemtags/src/utils.spec.ts | 4 +- apps/systemtags/src/utils.ts | 45 +- apps/systemtags/src/utils/colorUtils.ts | 23 +- .../src/views/SystemTagsSection.vue | 30 +- apps/theming/src/AdminTheming.vue | 39 +- apps/theming/src/UserTheming.vue | 59 +- apps/theming/src/admin-settings.js | 2 - .../src/components/AppOrderSelector.vue | 39 +- .../components/AppOrderSelectorElement.vue | 35 +- .../src/components/BackgroundSettings.vue | 38 +- apps/theming/src/components/ItemPreview.vue | 14 +- .../src/components/UserAppMenuSection.vue | 42 +- .../src/components/UserPrimaryColor.vue | 18 +- .../src/components/admin/AppMenuSection.vue | 52 +- .../src/components/admin/CheckboxField.vue | 12 +- .../src/components/admin/ColorPickerField.vue | 29 +- .../src/components/admin/FileInputField.vue | 38 +- .../src/components/admin/TextField.vue | 10 +- apps/theming/src/logger.ts | 11 + apps/theming/src/mixins/admin/FieldMixin.js | 4 +- .../src/mixins/admin/TextValueMixin.js | 9 +- apps/theming/src/personal-settings.js | 5 +- apps/twofactor_backupcodes/src/logger.ts | 10 + .../src/service/BackupCodesService.js | 2 +- apps/twofactor_backupcodes/src/settings.js | 1 - apps/twofactor_backupcodes/src/store.js | 2 +- .../src/views/PersonalSettings.vue | 33 +- .../src/components/AppChangelogDialog.vue | 10 +- .../src/components/Markdown.vue | 6 +- .../src/components/UpdateNotification.vue | 78 +- .../src/composables/useMarkdown.ts | 9 +- apps/updatenotification/src/init.ts | 11 +- apps/updatenotification/src/logger.ts | 11 + .../src/updatenotification.js | 4 +- apps/updatenotification/src/views/App.vue | 3 +- apps/user_ldap/js/renewPassword.js | 24 +- .../ui-multiselect/src/jquery.multiselect.js | 1236 ++++++++-------- .../components/SettingsTabs/AdvancedTab.vue | 121 +- .../src/components/SettingsTabs/ExpertTab.vue | 18 +- .../src/components/SettingsTabs/GroupsTab.vue | 50 +- .../src/components/SettingsTabs/LoginTab.vue | 67 +- .../src/components/SettingsTabs/ServerTab.vue | 71 +- .../src/components/SettingsTabs/UsersTab.vue | 46 +- .../src/components/WizardControls.vue | 31 +- apps/user_ldap/src/main.ts | 7 +- apps/user_ldap/src/models/index.ts | 28 +- .../src/services/ldapConfigService.ts | 104 +- apps/user_ldap/src/store/configs.ts | 28 +- apps/user_ldap/src/views/Settings.vue | 54 +- apps/user_status/src/UserStatus.vue | 23 +- .../src/components/ClearAtSelect.vue | 9 +- .../src/components/CustomMessageInput.vue | 11 +- .../src/components/OnlineStatusSelect.vue | 9 +- .../src/components/PredefinedStatus.vue | 10 +- .../src/components/PredefinedStatusesList.vue | 29 +- .../src/components/PreviousStatus.vue | 5 +- .../src/components/SetStatusModal.vue | 88 +- apps/user_status/src/filters/clearAtFilter.js | 14 +- apps/user_status/src/logger.ts | 11 + apps/user_status/src/menu.js | 11 +- .../src/mixins/OnlineStatusMixin.js | 40 +- .../src/services/clearAtOptionsService.js | 2 +- .../src/services/clearAtService.js | 10 +- apps/user_status/src/services/dateService.js | 5 +- .../src/services/heartbeatService.js | 2 +- .../src/services/predefinedStatusService.js | 2 +- .../src/services/statusOptionsService.js | 2 +- .../user_status/src/services/statusService.js | 22 +- apps/user_status/src/store/index.js | 2 +- .../user_status/src/store/userBackupStatus.js | 6 +- apps/user_status/src/store/userStatus.js | 20 +- apps/weather_status/src/App.vue | 163 ++- apps/weather_status/src/logger.ts | 11 + .../src/services/weatherStatusService.js | 26 +- apps/weather_status/src/weather-status.js | 1 - apps/workflowengine/src/components/Check.vue | 61 +- .../src/components/Checks/FileMimeType.vue | 19 +- .../src/components/Checks/FileSystemTag.vue | 8 +- .../src/components/Checks/RequestTime.vue | 21 +- .../src/components/Checks/RequestURL.vue | 19 +- .../components/Checks/RequestUserAgent.vue | 19 +- .../components/Checks/RequestUserGroup.vue | 30 +- .../src/components/Checks/file.js | 11 +- .../src/components/Checks/request.js | 4 +- apps/workflowengine/src/components/Event.vue | 21 +- .../src/components/Operation.vue | 5 +- apps/workflowengine/src/components/Rule.vue | 57 +- .../src/components/Workflow.vue | 41 +- apps/workflowengine/src/helpers/api.js | 6 +- apps/workflowengine/src/helpers/validators.js | 26 +- apps/workflowengine/src/helpers/window.js | 15 +- apps/workflowengine/src/logger.ts | 11 + apps/workflowengine/src/store.js | 20 +- apps/workflowengine/src/workflowengine.js | 15 +- babel.config.js | 8 +- ...ackSPDXPlugin.js => WebpackSPDXPlugin.cjs} | 7 +- core/js/login/authpicker.js | 18 +- core/js/login/grant.js | 2 +- core/js/mimetype.js | 66 +- core/js/publicshareauth.js | 61 +- core/js/select2-toggleselect.js | 47 +- core/js/tests/html-domparser.js | 28 +- core/js/tests/specHelper.js | 120 +- core/js/tests/specs/coreSpec.js | 1238 ++++++++-------- core/js/tests/specs/files/clientSpec.js | 1287 ++++++++--------- core/js/tests/specs/jquery.avatarSpec.js | 262 ++-- core/js/tests/specs/jquery.placeholderSpec.js | 35 +- core/js/tests/specs/l10nSpec.js | 126 +- core/js/tests/specs/mimeTypeSpec.js | 164 ++- core/js/tests/specs/oc-backbone-webdavSpec.js | 385 +++-- core/js/tests/specs/public/commentsSpec.js | 54 +- core/js/update.js | 175 ++- core/src/OC/appconfig.js | 23 +- core/src/OC/apps.js | 6 +- core/src/OC/backbone-webdav.js | 223 +-- core/src/OC/capabilities.js | 7 +- core/src/OC/currentuser.js | 5 +- core/src/OC/dialogs.js | 290 ++-- core/src/OC/eventsource.js | 26 +- core/src/OC/get_set.js | 42 +- core/src/OC/index.js | 78 +- core/src/OC/l10n.js | 4 +- core/src/OC/menu.js | 11 +- core/src/OC/msg.js | 2 +- core/src/OC/navigation.js | 12 +- core/src/OC/notification.js | 12 +- core/src/OC/password-confirmation.js | 1 + core/src/OC/query-string.js | 4 +- core/src/OC/routing.js | 2 +- core/src/OC/util.js | 25 +- core/src/OC/xhr-error.js | 32 +- core/src/OCP/appconfig.js | 4 +- core/src/OCP/collaboration.js | 2 +- core/src/OCP/index.js | 8 +- core/src/OCP/loader.js | 4 +- core/src/OCP/whatsnew.js | 17 +- core/src/Util/get-url-parameter.js | 5 +- core/src/ajax-cron.ts | 2 +- .../AccountMenu/AccountMenuEntry.vue | 11 +- .../AccountMenu/AccountMenuProfileEntry.vue | 9 +- core/src/components/AppMenu.vue | 23 +- core/src/components/AppMenuEntry.vue | 9 +- core/src/components/AppMenuIcon.vue | 3 +- core/src/components/ContactsMenu.js | 7 +- .../{Contact.vue => ContactMenuEntry.vue} | 27 +- core/src/components/LegacyDialogPrompt.vue | 12 +- core/src/components/MainMenu.js | 10 +- .../Profile/PrimaryActionButton.vue | 11 +- .../PublicPageMenu/PublicPageMenuEntry.vue | 10 +- .../PublicPageMenuExternalDialog.vue | 14 +- .../PublicPageMenuExternalEntry.vue | 3 +- .../PublicPageMenuLinkEntry.vue | 3 +- .../UnifiedSearch/CustomDateRangeModal.vue | 17 +- .../UnifiedSearch/LegacySearchResult.vue | 16 +- .../UnifiedSearch/SearchFilterChip.vue | 3 + .../components/UnifiedSearch/SearchResult.vue | 20 +- .../SearchResultPlaceholders.vue | 12 +- .../UnifiedSearch/SearchableList.vue | 26 +- .../UnifiedSearchLocalSearchBar.vue | 17 +- .../UnifiedSearch/UnifiedSearchModal.vue | 229 +-- core/src/components/UserMenu.js | 9 +- core/src/components/login/LoginButton.vue | 12 +- core/src/components/login/LoginForm.vue | 72 +- .../login/PasswordLessLoginForm.vue | 52 +- core/src/components/login/ResetPassword.vue | 25 +- core/src/components/login/UpdatePassword.vue | 16 +- core/src/components/setup/RecommendedApps.vue | 50 +- core/src/files/client.js | 329 +++-- core/src/files/fileinfo.js | 4 +- core/src/globals.js | 45 +- core/src/{icons.js => icons.cjs} | 188 +-- core/src/init.js | 39 +- core/src/install.ts | 2 +- core/src/jquery/avatar.js | 8 +- core/src/jquery/index.js | 1 - core/src/jquery/ocdialog.js | 143 +- core/src/jquery/octemplate.js | 10 +- core/src/jquery/placeholder.js | 7 +- core/src/jquery/requesttoken.js | 1 - core/src/jquery/showpassword.js | 10 +- core/src/legacy-unified-search.js | 9 +- core/src/logger.js | 6 +- core/src/login.js | 5 +- core/src/main.js | 23 +- core/src/maintenance.js | 18 +- core/src/mixins/Nextcloud.js | 2 +- core/src/public-page-menu.ts | 1 - core/src/public-page-user-menu.ts | 1 - core/src/recommendedapps.js | 4 +- core/src/services/BrowsersListService.js | 5 +- core/src/services/ContactsMenuService.ts | 2 - .../services/LegacyUnifiedSearchService.js | 7 +- core/src/services/UnifiedSearchService.js | 11 +- .../services/WebAuthnAuthenticationService.ts | 8 +- core/src/session-heartbeat.ts | 4 +- core/src/tests/OC/requesttoken.spec.ts | 4 +- ...ntact.spec.js => ContactMenuEntry.spec.js} | 7 +- core/src/tests/views/ContactsMenu.spec.js | 5 +- core/src/unified-search.ts | 21 +- core/src/unsupported-browser-redirect.js | 1 - core/src/unsupported-browser.js | 8 +- core/src/utils/ClipboardFallback.ts | 8 +- core/src/utils/RedirectUnsupportedBrowsers.js | 6 +- core/src/utils/xhr-request.js | 14 +- core/src/views/AccountMenu.vue | 36 +- core/src/views/ContactsMenu.vue | 35 +- core/src/views/LegacyUnifiedSearch.vue | 89 +- core/src/views/Login.vue | 47 +- core/src/views/PublicPageMenu.vue | 39 +- core/src/views/PublicPageUserMenu.vue | 19 +- core/src/views/Setup.cy.ts | 4 +- core/src/views/Setup.vue | 101 +- core/src/views/UnifiedSearch.vue | 12 +- core/src/views/UnsupportedBrowser.vue | 21 +- core/vendor/zxcvbn/dist/zxcvbn.js | 67 +- custom.d.ts | 2 +- cypress.config.ts | 16 +- cypress/dockerNode.ts | 66 +- cypress/e2e/core-utils.ts | 5 +- cypress/e2e/core/header_access-levels.cy.ts | 2 +- cypress/e2e/core/header_contacts-menu.cy.ts | 4 +- cypress/e2e/core/setup.ts | 1 - cypress/e2e/files/FilesUtils.ts | 149 +- cypress/e2e/files/LivePhotosUtils.ts | 20 +- cypress/e2e/files/favorites.cy.ts | 3 +- cypress/e2e/files/files-actions.cy.ts | 22 +- cypress/e2e/files/files-copy-move.cy.ts | 3 +- cypress/e2e/files/files-delete.cy.ts | 3 +- cypress/e2e/files/files-download.cy.ts | 7 +- cypress/e2e/files/files-filtering.cy.ts | 7 +- cypress/e2e/files/files-navigation.cy.ts | 1 + cypress/e2e/files/files-renaming.cy.ts | 7 +- cypress/e2e/files/files-selection.cy.ts | 6 +- cypress/e2e/files/files-sidebar.cy.ts | 5 +- cypress/e2e/files/files-sorting.cy.ts | 252 ++-- cypress/e2e/files/files.cy.ts | 2 +- cypress/e2e/files/live_photos.cy.ts | 5 +- cypress/e2e/files/new-menu.cy.ts | 3 +- cypress/e2e/files/recent-view.cy.ts | 3 +- cypress/e2e/files/router-query.cy.ts | 1 + cypress/e2e/files/scrolling.cy.ts | 4 +- cypress/e2e/files/search.cy.ts | 6 +- cypress/e2e/files_external/StorageUtils.ts | 18 +- .../files-external-failed.cy.ts | 13 +- .../files-user-credentials.cy.ts | 18 +- .../home-folder-root-mount-permissions.cy.ts | 9 +- .../e2e/files_sharing/FilesSharingUtils.ts | 7 +- cypress/e2e/files_sharing/ShareOptionsType.ts | 8 +- cypress/e2e/files_sharing/expiry-date.cy.ts | 4 +- cypress/e2e/files_sharing/file-request.cy.ts | 7 +- .../e2e/files_sharing/files-copy-move.cy.ts | 11 +- .../e2e/files_sharing/files-download.cy.ts | 3 +- .../e2e/files_sharing/files-shares-view.cy.ts | 3 +- .../files_sharing/limit_to_same_group.cy.ts | 13 +- .../e2e/files_sharing/note-to-recipient.cy.ts | 4 +- .../public-share/PublicShareUtils.ts | 15 +- .../public-share/copy-move-files.cy.ts | 1 - .../public-share/default-view.cy.ts | 2 +- .../files_sharing/public-share/download.cy.ts | 12 +- .../public-share/header-avatar.cy.ts | 5 +- .../public-share/header-menu.cy.ts | 6 +- .../public-share/rename-files.cy.ts | 1 - .../public-share/required-before-create.cy.ts | 123 +- .../public-share/sidebar-tab.cy.ts | 6 +- .../public-share/view_file-drop.cy.ts | 5 +- .../view_view-only-no-download.cy.ts | 1 - .../public-share/view_view-only.cy.ts | 1 - .../files_sharing/share-status-action.cy.ts | 3 +- .../files_trashbin/files-trash-action.cy.ts | 2 +- .../e2e/files_versions/filesVersionsUtils.ts | 12 +- .../e2e/files_versions/version_creation.cy.ts | 2 +- .../version_cross_share_move_and_copy.cy.ts | 5 +- .../e2e/files_versions/version_deletion.cy.ts | 11 +- .../e2e/files_versions/version_download.cy.ts | 9 +- .../files_versions/version_expiration.cy.ts | 2 +- .../e2e/files_versions/version_naming.cy.ts | 9 +- .../files_versions/version_restoration.cy.ts | 9 +- .../e2e/files_versions/version_sharing.cy.ts | 3 +- cypress/e2e/login/login-redirect.cy.ts | 2 - cypress/e2e/login/login.cy.ts | 3 +- cypress/e2e/settings/access-levels.cy.ts | 2 +- cypress/e2e/settings/apps.cy.ts | 2 +- cypress/e2e/settings/personal-info.cy.ts | 9 +- cypress/e2e/settings/users-group-admin.cy.ts | 5 +- cypress/e2e/settings/users.cy.ts | 3 +- cypress/e2e/settings/usersUtils.ts | 12 +- cypress/e2e/settings/users_columns.cy.ts | 6 +- cypress/e2e/settings/users_disable.cy.ts | 4 +- cypress/e2e/settings/users_groups.cy.ts | 8 +- cypress/e2e/settings/users_manager.cy.ts | 6 +- cypress/e2e/settings/users_modify.cy.ts | 8 +- cypress/e2e/systemtags/admin-settings.cy.ts | 12 +- .../e2e/systemtags/files-bulk-action.cy.ts | 10 +- .../e2e/systemtags/files-inline-action.cy.ts | 2 +- cypress/e2e/systemtags/files-sidebar.cy.ts | 1 + cypress/e2e/theming/a11y-color-contrast.cy.ts | 8 +- cypress/e2e/theming/admin-settings.cy.ts | 257 ++-- .../theming/admin-settings_default-app.cy.ts | 7 +- cypress/e2e/theming/admin-settings_urls.cy.ts | 2 - cypress/e2e/theming/themingUtils.ts | 23 +- .../e2e/theming/user-settings_app-order.cy.ts | 7 +- .../theming/user-settings_background.cy.ts | 10 +- cypress/pages/FilesFilters.ts | 2 - cypress/pages/FilesNavigation.ts | 2 - cypress/pages/NavigationHeader.ts | 3 +- cypress/pages/UnifiedSearch.ts | 2 - cypress/support/commands.ts | 20 +- cypress/support/commonUtils.ts | 2 +- cypress/support/component.ts | 6 +- cypress/support/cypress-component.d.ts | 2 +- cypress/support/cypress-e2e.d.ts | 22 +- cypress/support/e2e.ts | 6 +- cypress/support/utils/assertions.ts | 6 +- eslint.config.mjs | 10 +- stylelint.config.js | 13 +- vitest.config.mts | 3 +- webpack.common.cjs | 40 +- window.d.ts | 6 +- 807 files changed, 13340 insertions(+), 10372 deletions(-) create mode 100644 apps/dashboard/src/logger.ts rename apps/files/src/components/{Setting.vue => FilesAppSettingsEntry.vue} (90%) rename apps/files/src/views/{Settings.vue => FilesAppSettings.vue} (88%) rename apps/files/src/views/{Navigation.cy.ts => FilesNavigation.cy.ts} (92%) rename apps/files/src/views/{Navigation.vue => FilesNavigation.vue} (91%) rename apps/files/src/views/{Sidebar.vue => FilesSidebar.vue} (95%) rename apps/files_versions/src/components/{Version.vue => VersionEntry.vue} (91%) rename apps/profile/src/views/{Profile.vue => ProfileApp.vue} (90%) rename apps/settings/src/components/PersonalInfo/EmailSection/{Email.vue => EmailSectionEntry.vue} (92%) rename apps/settings/src/components/PersonalInfo/LanguageSection/{Language.vue => LanguageSectionEntry.vue} (89%) rename apps/settings/src/components/PersonalInfo/LocaleSection/{Locale.vue => LocaleSectionEntry.vue} (92%) rename apps/settings/src/components/WebAuthn/{AddDevice.vue => WebAuthnAddDevice.vue} (87%) rename apps/settings/src/components/WebAuthn/{Device.vue => WebAuthnDevice.vue} (97%) rename apps/settings/src/components/WebAuthn/{Section.vue => WebAuthnSection.vue} (86%) create mode 100644 apps/sharebymail/src/logger.ts create mode 100644 apps/theming/src/logger.ts create mode 100644 apps/twofactor_backupcodes/src/logger.ts create mode 100644 apps/updatenotification/src/logger.ts create mode 100644 apps/user_status/src/logger.ts create mode 100644 apps/weather_status/src/logger.ts create mode 100644 apps/workflowengine/src/logger.ts rename build/{WebpackSPDXPlugin.js => WebpackSPDXPlugin.cjs} (99%) rename core/src/components/ContactsMenu/{Contact.vue => ContactMenuEntry.vue} (94%) rename core/src/{icons.js => icons.cjs} (67%) rename core/src/tests/components/ContactsMenu/{Contact.spec.js => ContactMenuEntry.spec.js} (88%) diff --git a/__mocks__/@nextcloud/auth.ts b/__mocks__/@nextcloud/auth.ts index 8d341dadad7..85aa2042b06 100644 --- a/__mocks__/@nextcloud/auth.ts +++ b/__mocks__/@nextcloud/auth.ts @@ -2,7 +2,8 @@ * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -export const getCurrentUser = function() { + +export function getCurrentUser() { return { uid: 'test', displayName: 'Test', @@ -10,8 +11,8 @@ export const getCurrentUser = function() { } } -export const getRequestToken = function() { +export function getRequestToken() { return 'test-token-1234' } -export const onRequestTokenUpdate = function() {} +export function onRequestTokenUpdate() {} diff --git a/__mocks__/@nextcloud/capabilities.ts b/__mocks__/@nextcloud/capabilities.ts index b2b33773403..a8943a68306 100644 --- a/__mocks__/@nextcloud/capabilities.ts +++ b/__mocks__/@nextcloud/capabilities.ts @@ -2,9 +2,10 @@ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -import type { Capabilities } from '../../apps/files/src/types' -export const getCapabilities = (): Capabilities => { +import type { Capabilities } from '../../apps/files/src/types.ts' + +export function getCapabilities(): Capabilities { return { files: { bigfilechunking: true, diff --git a/__mocks__/@nextcloud/initial-state.ts b/__mocks__/@nextcloud/initial-state.ts index a562259b93f..9955bcd8b3b 100644 --- a/__mocks__/@nextcloud/initial-state.ts +++ b/__mocks__/@nextcloud/initial-state.ts @@ -3,6 +3,6 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ -export const loadState = function(app: string, key: string, fallback?: any) { +export function loadState(app: string, key: string, fallback?: any) { return fallback } diff --git a/__mocks__/webdav.ts b/__mocks__/webdav.ts index 7f56c7000b0..8ac599f9e49 100644 --- a/__mocks__/webdav.ts +++ b/__mocks__/webdav.ts @@ -2,9 +2,10 @@ * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -export const createClient = () => {} -export const getPatcher = () => { + +export function createClient() {} +export function getPatcher() { return { - patch: () => {} + patch: () => {}, } } diff --git a/__tests__/FileSystemAPIUtils.ts b/__tests__/FileSystemAPIUtils.ts index d03bbf2d586..9e72fb16389 100644 --- a/__tests__/FileSystemAPIUtils.ts +++ b/__tests__/FileSystemAPIUtils.ts @@ -2,11 +2,11 @@ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -import { basename } from 'node:path' + import mime from 'mime' +import { basename } from 'node:path' class FileSystemEntry { - private _isFile: boolean private _fullPath: string @@ -26,11 +26,9 @@ class FileSystemEntry { get name() { return basename(this._fullPath) } - } export class FileSystemFileEntry extends FileSystemEntry { - private _contents: string private _lastModified: number @@ -46,11 +44,9 @@ export class FileSystemFileEntry extends FileSystemEntry { const type = mime.getType(this.name) || '' success(new File([this._contents], this.name, { lastModified, type })) } - } export class FileSystemDirectoryEntry extends FileSystemEntry { - private _entries: FileSystemEntry[] constructor(fullPath: string, entries: FileSystemEntry[]) { @@ -70,7 +66,6 @@ export class FileSystemDirectoryEntry extends FileSystemEntry { }, } } - } /** @@ -79,7 +74,6 @@ export class FileSystemDirectoryEntry extends FileSystemEntry { * File API in the same test suite. */ export class DataTransferItem { - private _type: string private _entry: FileSystemEntry @@ -104,7 +98,7 @@ export class DataTransferItem { return this._type } - getAsFile(): File|null { + getAsFile(): File | null { if (this._entry.isFile && this._entry instanceof FileSystemFileEntry) { let file: File | null = null this._entry.file((f) => { @@ -116,10 +110,9 @@ export class DataTransferItem { // The browser will return an empty File object if the entry is a directory return new File([], this._entry.name, { type: '' }) } - } -export const fileSystemEntryToDataTransferItem = (entry: FileSystemEntry, isFileSystemAPIAvailable = true): DataTransferItem => { +export function fileSystemEntryToDataTransferItem(entry: FileSystemEntry, isFileSystemAPIAvailable = true): DataTransferItem { return new DataTransferItem( entry.isFile ? 'text/plain' : 'httpd/unix-directory', entry, diff --git a/apps/comments/src/actions/inlineUnreadCommentsAction.spec.ts b/apps/comments/src/actions/inlineUnreadCommentsAction.spec.ts index e8020f1f029..7894afab214 100644 --- a/apps/comments/src/actions/inlineUnreadCommentsAction.spec.ts +++ b/apps/comments/src/actions/inlineUnreadCommentsAction.spec.ts @@ -2,11 +2,13 @@ * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -import { File, Permission, View, FileAction } from '@nextcloud/files' -import { describe, expect, test, vi } from 'vitest' -import { action } from './inlineUnreadCommentsAction' -import logger from '../logger' +import type { View } from '@nextcloud/files' + +import { File, FileAction, Permission } from '@nextcloud/files' +import { describe, expect, test, vi } from 'vitest' +import logger from '../logger.js' +import { action } from './inlineUnreadCommentsAction.ts' const view = { id: 'files', @@ -120,6 +122,7 @@ describe('Inline unread comments action execute tests', () => { const setActiveTabMock = vi.fn() window.OCA = { Files: { + // @ts-expect-error Mocking for testing Sidebar: { open: openMock, setActiveTab: setActiveTabMock, @@ -146,10 +149,13 @@ describe('Inline unread comments action execute tests', () => { }) test('Action handles sidebar open failure', async () => { - const openMock = vi.fn(() => { throw new Error('Mock error') }) + const openMock = vi.fn(() => { + throw new Error('Mock error') + }) const setActiveTabMock = vi.fn() window.OCA = { Files: { + // @ts-expect-error Mocking for testing Sidebar: { open: openMock, setActiveTab: setActiveTabMock, diff --git a/apps/comments/src/actions/inlineUnreadCommentsAction.ts b/apps/comments/src/actions/inlineUnreadCommentsAction.ts index 0afd93d7606..302107604ba 100644 --- a/apps/comments/src/actions/inlineUnreadCommentsAction.ts +++ b/apps/comments/src/actions/inlineUnreadCommentsAction.ts @@ -2,11 +2,13 @@ * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -import { FileAction, Node } from '@nextcloud/files' -import { translate as t, translatePlural as n } from '@nextcloud/l10n' -import CommentProcessingSvg from '@mdi/svg/svg/comment-processing.svg?raw' -import logger from '../logger' +import type { Node } from '@nextcloud/files' + +import CommentProcessingSvg from '@mdi/svg/svg/comment-processing.svg?raw' +import { FileAction } from '@nextcloud/files' +import { n, t } from '@nextcloud/l10n' +import logger from '../logger.js' export const action = new FileAction({ id: 'comments-unread', @@ -25,7 +27,7 @@ export const action = new FileAction({ iconSvgInline: () => CommentProcessingSvg, enabled(nodes: Node[]) { - const unread = nodes[0].attributes['comments-unread'] as number|undefined + const unread = nodes[0].attributes['comments-unread'] as number | undefined return typeof unread === 'number' && unread > 0 }, diff --git a/apps/comments/src/comments-activity-tab.ts b/apps/comments/src/comments-activity-tab.ts index 77f6c9bca04..1c6eef75b8e 100644 --- a/apps/comments/src/comments-activity-tab.ts +++ b/apps/comments/src/comments-activity-tab.ts @@ -2,13 +2,13 @@ * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ + import moment from '@nextcloud/moment' +import { createPinia, PiniaVuePlugin } from 'pinia' import Vue, { type ComponentPublicInstance } from 'vue' import logger from './logger.js' import { getComments } from './services/GetComments.js' -import { PiniaVuePlugin, createPinia } from 'pinia' - Vue.use(PiniaVuePlugin) let ActivityTabPluginView diff --git a/apps/comments/src/comments-app.js b/apps/comments/src/comments-app.js index a91a4bb37bb..ea99517e280 100644 --- a/apps/comments/src/comments-app.js +++ b/apps/comments/src/comments-app.js @@ -3,6 +3,7 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ +import logger from './logger.js' import CommentsInstance from './services/CommentsInstance.js' // Init Comments @@ -12,4 +13,4 @@ if (window.OCA && !window.OCA.Comments) { // Init Comments App view Object.assign(window.OCA.Comments, { View: CommentsInstance }) -console.debug('OCA.Comments.View initialized') +logger.debug('OCA.Comments.View initialized') diff --git a/apps/comments/src/comments-tab.js b/apps/comments/src/comments-tab.js index d3ebe3e9596..044ba4a60eb 100644 --- a/apps/comments/src/comments-tab.js +++ b/apps/comments/src/comments-tab.js @@ -3,7 +3,6 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ -// eslint-disable-next-line n/no-missing-import, import/no-unresolved import MessageReplyText from '@mdi/svg/svg/message-reply-text.svg?raw' import { getCSPNonce } from '@nextcloud/auth' import { loadState } from '@nextcloud/initial-state' diff --git a/apps/comments/src/components/Comment.vue b/apps/comments/src/components/Comment.vue index 970bb444f42..a658598bb9d 100644 --- a/apps/comments/src/components/Comment.vue +++ b/apps/comments/src/components/Comment.vue @@ -3,14 +3,16 @@ - SPDX-License-Identifier: AGPL-3.0-or-later -->