Merge pull request #41580 from nextcloud/fix/a11y-replace_action_link_with_action_button

Replace ActionLink with ActionButton on sharing tab

apps/files_sharing/src/components/SharingEntryInternal.vue

@@ -8,12 +8,10 @@
 				<div class="avatar-external icon-external-white" />
 			</template>
 
-			<NcActionLink :href="internalLink"
+			<NcActionButton :title="copyLinkTooltip"
 				:aria-label="copyLinkTooltip"
-				:title="copyLinkTooltip"
-				target="_blank"
 				:icon="copied && copySuccess ? 'icon-checkmark-color' : 'icon-clippy'"
-				@click.prevent="copyLink" />
+				@click="copyLink" />
 		</SharingEntrySimple>
 	</ul>
 </template>
@@ -21,14 +19,14 @@
 <script>
 import { generateUrl } from '@nextcloud/router'
 import { showSuccess } from '@nextcloud/dialogs'
-import NcActionLink from '@nextcloud/vue/dist/Components/NcActionLink.js'
+import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'
 import SharingEntrySimple from './SharingEntrySimple.vue'
 
 export default {
 	name: 'SharingEntryInternal',
 
 	components: {
-		NcActionLink,
+		NcActionButton,
 		SharingEntrySimple,
 	},
 
@@ -85,7 +83,6 @@ export default {
 			try {
 				await navigator.clipboard.writeText(this.internalLink)
 				showSuccess(t('files_sharing', 'Link copied'))
-				// focus and show the tooltip (note: cannot set ref on NcActionLink)
 				this.$refs.shareEntrySimple.$refs.actionsComponent.$el.focus()
 				this.copySuccess = true
 				this.copied = true

apps/files_sharing/src/components/SharingEntryLink.vue

@@ -43,12 +43,10 @@
 
 			<!-- clipboard -->
 			<NcActions v-if="share && !isEmailShareType && share.token" ref="copyButton" class="sharing-entry__copy">
-				<NcActionLink :href="shareLink"
-					target="_blank"
-					:title="copyLinkTooltip"
+				<NcActionButton	:title="copyLinkTooltip"
 					:aria-label="copyLinkTooltip"
 					:icon="copied && copySuccess ? 'icon-checkmark-color' : 'icon-clippy'"
-					@click.stop.prevent="copyLink" />
+					@click.prevent="copyLink" />
 			</NcActions>
 		</div>