upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

Improve unit testing for Util::addScript() and Util::getScript()

Browse source 
Instead of checking for a predefined order of the scripts, test the
logic: core first, dependencies before their children, no duplicates and
all scripts still listed.

Signed-off-by: Jonas Meurer <jonas@freesources.org>
This commit is contained in:
Jonas Meurer 2021-12-17 13:26:43 +01:00
parent 7ec1317b1b
commit 8dd119402a
No known key found for this signature in database
GPG key ID: 5262E7FF491049FE
1 changed files with 52 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
tests/lib/UtilTest.php
View file

@ -238,22 +238,70 @@ class UtilTest extends \Test\TestCase {
public function testAddScript() {
\OCP\Util::addScript('core', 'myFancyJSFile1');
\OCP\Util::addScript('files', 'myFancyJSFile2', 'core');
\OCP\Util::addScript('myApp5', 'myApp5JSFile', 'myApp2');
\OCP\Util::addScript('myApp', 'myFancyJSFile3');
\OCP\Util::addScript('core', 'myFancyJSFile4');
// after itself
\OCP\Util::addScript('core', 'myFancyJSFile5', 'core');
// add duplicate
\OCP\Util::addScript('core', 'myFancyJSFile1');
// dependency chain
\OCP\Util::addScript('myApp4', 'myApp4JSFile', 'myApp3');
\OCP\Util::addScript('myApp3', 'myApp3JSFile', 'myApp2');
\OCP\Util::addScript('myApp2', 'myApp2JSFile', 'myApp');
$this->assertEquals([
// Core should appear first
$this->assertEquals(
0,
array_search('core/js/myFancyJSFile1', \OCP\Util::getScripts(), true)
);
$this->assertEquals(
1,
array_search('core/js/myFancyJSFile4', \OCP\Util::getScripts(), true)
);
// Dependencies should appear before their children
$this->assertLessThan(
array_search('files/js/myFancyJSFile2', \OCP\Util::getScripts(), true),
array_search('core/js/myFancyJSFile3', \OCP\Util::getScripts(), true)
);
$this->assertLessThan(
array_search('myApp2/js/myApp2JSFile', \OCP\Util::getScripts(), true),
array_search('myApp/js/myFancyJSFile3', \OCP\Util::getScripts(), true)
);
$this->assertLessThan(
array_search('myApp3/js/myApp3JSFile', \OCP\Util::getScripts(), true),
array_search('myApp2/js/myApp2JSFile', \OCP\Util::getScripts(), true)
);
$this->assertLessThan(
array_search('myApp4/js/myApp4JSFile', \OCP\Util::getScripts(), true),
array_search('myApp3/js/myApp3JSFile', \OCP\Util::getScripts(), true)
);
$this->assertLessThan(
array_search('myApp5/js/myApp5JSFile', \OCP\Util::getScripts(), true),
array_search('myApp2/js/myApp2JSFile', \OCP\Util::getScripts(), true)
);
// No duplicates
$this->assertEquals(
\OCP\Util::getScripts(),
array_unique(\OCP\Util::getScripts())
);
// All scripts still there
$scripts = [
'core/js/myFancyJSFile1',
'core/js/myFancyJSFile4',
'files/js/myFancyJSFile2',
'core/js/myFancyJSFile5',
'files/l10n/en',
'myApp/l10n/en',
'myApp/js/myFancyJSFile3',
], array_values(\OCP\Util::getScripts()));
'myApp2/js/myApp2JSFile',
'myApp3/js/myApp3JSFile',
'myApp4/js/myApp4JSFile',
];
foreach ($scripts as $script) {
$this->assertContains($script, \OCP\Util::getScripts());
}
}
public function testAddVendorScript() {