From 88a5aca1ff6583a66e7a6c20a9ca61f5e0433bde Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Thu, 26 Mar 2026 11:32:42 +0100 Subject: [PATCH] fix(settings): Check all values first, then apply them Signed-off-by: Marcel Klehr --- apps/settings/lib/Controller/AISettingsController.php | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/apps/settings/lib/Controller/AISettingsController.php b/apps/settings/lib/Controller/AISettingsController.php index 2bc0271373a..512afe9d3fd 100644 --- a/apps/settings/lib/Controller/AISettingsController.php +++ b/apps/settings/lib/Controller/AISettingsController.php @@ -44,15 +44,20 @@ class AISettingsController extends Controller { continue; } try { - $value = json_encode($settings[$key], flags: \JSON_THROW_ON_ERROR); + $settings[$key] = json_encode($settings[$key], flags: \JSON_THROW_ON_ERROR); } catch (\JsonException) { return new DataResponse(['error' => "Setting value for '$key' must be JSON-compatible"], Http::STATUS_BAD_REQUEST); } - $changed = $this->appConfig->setValueString('core', $key, $value, lazy: in_array($key, \OC\TaskProcessing\Manager::LAZY_CONFIG_KEYS, true)); + } + foreach ($keys as $key) { + if (!isset($settings[$key])) { + continue; + } + $changed = $this->appConfig->setValueString('core', $key, $settings[$key], lazy: in_array($key, \OC\TaskProcessing\Manager::LAZY_CONFIG_KEYS, true)); if ($changed) { $this->eventDispatcher->dispatchTyped(new CriticalActionPerformedEvent( 'AI configuration was changed by user %s: %s was set to %s', - [$this->userId, $key, $value] + [$this->userId, $key, $settings[$key]] )); } }