upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-08 08:16:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Merge pull request #41399 from nextcloud/fix/cypress-flaky-new-users

Browse source 
fix(cypress): Make new-users test less flaky by using test isolation
This commit is contained in:
Ferdinand Thiessen 2023-11-17 22:29:49 +01:00 committed by GitHub
commit 84429003e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
cypress/e2e/settings/users.cy.ts
View file

@ -27,25 +27,18 @@ const admin = new User('admin', 'admin')
const john = new User('john', '123456')
describe('Settings: Create and delete users', function() {
before(function() {
beforeEach(function() {
cy.listUsers().then((users) => {
if ((users as string[]).includes(john.userId)) {
// ensure created user is deleted
cy.deleteUser(john)
}
})
cy.login(admin)
// open the User settings
cy.visit('/settings/users')
})
beforeEach(function() {
cy.login(admin)
cy.listUsers().then((users) => {
cy.login(admin)
if ((users as string[]).includes(john.userId)) {
// ensure created user is deleted
cy.deleteUser(john).login(admin)
// ensure deleted user is not present
cy.reload().login(admin)
}
})
})
it('Can create a user', function() {
// open the New user modal
cy.get('button#new-user-button').click()
@ -64,7 +57,7 @@ describe('Settings: Create and delete users', function() {
// see that the password is 123456
cy.get('input[type="password"]').should('have.value', john.password)
// submit the new user form
cy.get('button[type="submit"]').click()
cy.get('button[type="submit"]').click({ force: true })
})
// Make sure no confirmation modal is shown
@ -98,7 +91,7 @@ describe('Settings: Create and delete users', function() {
cy.get('input[type="password"]').type(john.password)
cy.get('input[type="password"]').should('have.value', john.password)
// submit the new user form
cy.get('button[type="submit"]').click()
cy.get('button[type="submit"]').click({ force: true })
})
// Make sure no confirmation modal is shown