Merge pull request #42583 from nextcloud/backport/42576/stable28

[stable28] Fix upgrade of user_ldap when oc_group_members contains duplicated uids
This commit is contained in:
Côme Chilliet 2024-01-04 15:37:43 +01:00 committed by GitHub
commit 80b5aed6ef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -99,13 +99,21 @@ class Version1190Date20230706134108 extends SimpleMigrationStep {
$result = $query->executeQuery();
while ($row = $result->fetch()) {
$knownUsers = unserialize($row['owncloudusers']);
$knownUsers = array_unique($knownUsers);
foreach ($knownUsers as $knownUser) {
$insert
->setParameter('groupid', $row['owncloudname'])
->setParameter('userid', $knownUser)
;
try {
$insert
->setParameter('groupid', $row['owncloudname'])
->setParameter('userid', $knownUser)
;
$insert->executeStatement();
$insert->executeStatement();
} catch (\OCP\DB\Exception $e) {
/*
* If it fails on unique constaint violation it may just be left over value from previous half-migration
* If it fails on something else, ignore as well, data will be filled by background job later anyway
*/
}
}
}
$result->closeCursor();