upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-18 18:28:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

Additional index on oc_preferences to make sure that gettingh values without a user filter is fast

Browse source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl 2022-02-07 09:55:39 +01:00
parent cd95fce105
commit 7fbd93b2ad
No known key found for this signature in database
GPG key ID: 4C614C6ED2CDE6DF
4 changed files with 25 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/Application.php
View file

@ -213,6 +213,13 @@ class Application extends App {
$subject->addHintForMissingSubject($table->getName(), 'direct_edit_timestamp');
}
}
if ($schema->hasTable('preferences')) {
$table = $schema->getTable('preferences');
if (!$table->hasIndex('preferences_app_key')) {
$subject->addHintForMissingSubject($table->getName(), 'preferences_app_key');
}
}
}
);

13
core/Command/Db/AddMissingIndices.php
View file

@ -435,6 +435,19 @@ class AddMissingIndices extends Command {
}
}
$output->writeln('<info>Check indices of the oc_preferences table.</info>');
if ($schema->hasTable('preferences')) {
$table = $schema->getTable('preferences');
if (!$table->hasIndex('preferences_app_key')) {
$output->writeln('<info>Adding preferences_app_key index to the oc_preferences table, this can take some time...</info>');
$table->addIndex(['appid', 'configkey'], 'preferences_app_key');
$this->connection->migrateToSchema($schema->getWrappedSchema());
$updated = true;
$output->writeln('<info>oc_properties table updated successfully.</info>');
}
}
if (!$updated) {
$output->writeln('<info>Done.</info>');
}

1
core/Migrations/Version13000Date20170718121200.php
View file

@ -333,6 +333,7 @@ class Version13000Date20170718121200 extends SimpleMigrationStep {
'notnull' => false,
]);
$table->setPrimaryKey(['userid', 'appid', 'configkey']);
$table->addIndex(['appid', 'configkey'], 'preferences_app_key');
}
if (!$schema->hasTable('properties')) {

4
lib/private/AllConfig.php
View file

@ -497,6 +497,8 @@ class AllConfig implements \OCP\IConfig {
$sql .= 'AND `configvalue` = ?';
}
$sql .= ' ORDER BY `userid`';
$result = $this->connection->executeQuery($sql, [$appName, $key, $value]);
$userIDs = [];
@ -534,6 +536,8 @@ class AllConfig implements \OCP\IConfig {
$sql .= 'AND LOWER(`configvalue`) = ?';
}
$sql .= ' ORDER BY `userid`';
$result = $this->connection->executeQuery($sql, [$appName, $key, strtolower($value)]);
$userIDs = [];