+
- class="active"> diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php index 33de9d5f72f..217dd19c3d2 100644 --- a/core/templates/layout.user.php +++ b/core/templates/layout.user.php @@ -41,7 +41,7 @@
- class="active">
From 657a61e5379431a89596df9461e62bafcd6ee0da Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt
Date: Tue, 2 Aug 2011 02:29:51 +0200 Subject: [PATCH 07/14] no more misclicking files on checkbox ticking --- files/css/files.css | 8 ++++---- files/templates/part.list.php | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/files/css/files.css b/files/css/files.css index d7d681e66a3..9fa018a0153 100644 --- a/files/css/files.css +++ b/files/css/files.css @@ -27,16 +27,16 @@ table th { height:2em; padding:0 .5em; color:#999; } table th .name { float:left; margin-left:.5em; } table th.multiselect { background:#ddd; color:#000; font-weight:bold; } table th, table td { border-bottom:1px solid #ddd; text-align:left; font-weight:normal; } -table td { border-bottom:1px solid #eee; font-style:normal; } +table td { border-bottom:1px solid #eee; font-style:normal; background-position:1em .5em; background-repeat:no-repeat; } table th#headerSize, table td.filesize { width:5em; padding:0 1em; text-align:right; } table th#headerDate, table td.date { width:11em; padding:0 .1em 0 1em; text-align:left; } table td.selection, table th.selection, table td.fileaction { width:2em; text-align:center; } -table td.filename a.name { display:block; background-image:url('../img/file.png'); height:1.5em; vertical-align:middle; } +table td.filename a.name { display:block; height:1.5em; vertical-align:middle; margin-left:3em; } table tr[data-type="dir"] td.filename a.name {font-weight:bold; } table td.filename a.name input, table td.filename a.name form { width:100%; cursor:text } -table td.filename a, table td.login, table td.logout, table td.download, table td.upload, table td.create, table td.delete { padding:.2em .5em .5em 3em; background-position:1em .5em; background-repeat:no-repeat; } +table td.filename a, table td.login, table td.logout, table td.download, table td.upload, table td.create, table td.delete { padding:.2em .5em .5em 0; } table td.filename .nametext, .modified { float:left; padding:.3em 0; } -table td.filename .nametext { width:80%; } +table td.filename .nametext { width:60%; } table td.filename form { float:left; font-size:.85em; } #fileList tr input[type=checkbox] { display:none; float:left; margin:.7em 0 0 1em; /* bigger clickable area doesn’t work in FF width:2.8em; height:2.4em;*/ } #fileList tr input[type=checkbox]:checked, #fileList tr:hover input[type=checkbox] { display:inline; } diff --git a/files/templates/part.list.php b/files/templates/part.list.php index 93ed70990b7..5051c19949a 100644 --- a/files/templates/part.list.php +++ b/files/templates/part.list.php @@ -7,9 +7,9 @@ $relative_date_color = round((time()-$file['mtime'])/60/60/24*14); // the older the file, the brighter the shade of grey; days*14 if($relative_date_color>200) $relative_date_color = 200; ?> '> - + - + From 5c941e57d289154d5c4de0aa8fb59467a8562e5f Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Tue, 2 Aug 2011 03:17:26 +0200 Subject: [PATCH 08/14] fixed showing mimetypes for new files --- files/js/filelist.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/files/js/filelist.js b/files/js/filelist.js index 3f9b3984465..243c1113a47 100644 --- a/files/js/filelist.js +++ b/files/js/filelist.js @@ -12,8 +12,8 @@ FileList={ var basename=name; var extention=false; } - html+=' '; - html+=''+basename + html+=' '; + html+=''+basename if(extention){ html+=''+extention+''; } @@ -38,7 +38,7 @@ FileList={ }, addDir:function(name,size,lastModified){ var html=' '; - html+=' '+name+' '; + html+=''+name+' '; if(size!='Pending'){ simpleSize=simpleFileSize(size); }else{ @@ -103,7 +103,7 @@ FileList={ loadingDone:function(name){ $('tr[data-file="'+name+'"]').data('loading',false); var mime=$('tr[data-file="'+name+'"]').data('mime'); - $('tr[data-file="'+name+'"] td.filename a').attr('style','background-image:url('+getMimeIcon(mime)+')'); + $('tr[data-file="'+name+'"] td.filename').attr('style','background-image:url('+getMimeIcon(mime)+')'); $('tr[data-file="'+name+'"] td.filename').draggable(dragOptions); }, isLoading:function(name){ From b5c213ce6dad6cec98fd337e0458a370ad4b0869 Mon Sep 17 00:00:00 2001 From: Jan-Christoph BorchardtDate: Tue, 2 Aug 2011 03:59:25 +0200 Subject: [PATCH 09/14] fixed starting breadcrumb divider --- files/css/files.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/files/css/files.css b/files/css/files.css index 9fa018a0153..3ae578f30d4 100644 --- a/files/css/files.css +++ b/files/css/files.css @@ -21,6 +21,7 @@ tbody tr:hover, tbody tr:active, tbody tr.selected { background-color:#eee; heig tbody a { color:#000; } span.extention, td.date { color:#999; } div.crumb { float:left; display:block; background:no-repeat right 0; padding:8px 1.5em 0 1em; height:28px; /*36-8*/ } +div.crumb:first-child { padding-left:1.5em; } div.crumb:last-child { font-weight:bold; } table tr.mouseOver td { background-color:#eee; } table th { height:2em; padding:0 .5em; color:#999; } @@ -48,4 +49,4 @@ table td.filename form { float:left; font-size:.85em; } .selectedActions a:hover, a.file_action:hover { background:#fff; -moz-box-shadow:0 0 10px #fff; -webkit-box-shadow:0 0 10px #fff; box-shadow:0 0 10px #fff; -moz-border-radius:10px; -webkit-border-radius:10px; border-radius:10px; } /* add breadcrumb divider to the File item in navigation panel */ -#plugins>ul>li:first-child { background-position:15.7em 0px; background-repeat:no-repeat; background-image:url("/owncloud/core/img/breadcrumb-divider-start.png"); width:15.7em; padding-right:11px; } +#navigation>ul>li:first-child { background:url('../../core/img/breadcrumb-divider-start.png') no-repeat 12.5em 0px; width:12.5em; padding-right:1em; } From c814f10d7f7f104a67ea0de02c8eb9090c01a169 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 2 Aug 2011 04:13:19 +0200 Subject: [PATCH 10/14] fix media sub navigation entries --- apps/media/js/music.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/media/js/music.js b/apps/media/js/music.js index d5511279717..4e11b2951be 100644 --- a/apps/media/js/music.js +++ b/apps/media/js/music.js @@ -1,13 +1,13 @@ $(document).ready(function(){ //load the collection - $('#plugins a[href="#collection"]').click(function(){ - $('#plugins li.subentry a.active').removeClass('active'); + $('#navigation a[href="#collection"]').click(function(){ + $('#navigation li.subentry a.active').removeClass('active'); $(this).addClass('active'); PlayList.hide(); Collection.display(); }); - $('#plugins a[href="#playlist"]').click(function(){ - $('#plugins li.subentry a.active').removeClass('active'); + $('#navigation a[href="#playlist"]').click(function(){ + $('#navigation li.subentry a.active').removeClass('active'); $(this).addClass('active'); PlayList.render(); Collection.hide(); @@ -15,7 +15,7 @@ $(document).ready(function(){ var tab=window.location.href.slice(window.location.href.indexOf('#') + 1); PlayList.init('mp3',function(){ if(tab=='collection'){ - $('#plugins a[href="#collection"]').trigger('click'); + $('#navigation a[href="#collection"]').trigger('click'); } }); OC.search.customResults.Music=function(row,item){ From c0e7cf2e4029d7c9721fec59ac9dbf5c4985de0c Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 2 Aug 2011 04:26:32 +0200 Subject: [PATCH 11/14] remove now useless 'media' entry from settings --- apps/media/ajax/api.php | 7 ----- apps/media/appinfo/app.php | 1 - apps/media/settings.php | 52 -------------------------------------- 3 files changed, 60 deletions(-) delete mode 100644 apps/media/settings.php diff --git a/apps/media/ajax/api.php b/apps/media/ajax/api.php index 60458167a96..8fcabbf840e 100644 --- a/apps/media/ajax/api.php +++ b/apps/media/ajax/api.php @@ -84,13 +84,6 @@ if($arguments['action']){ OC_DB::beginTransaction(); set_time_limit(0); //recursive scan can take a while $path=$arguments['path']; - if(OC_Filesystem::is_dir($path)){ - $paths=explode(PATH_SEPARATOR,OC_Preferences::getValue(OC_User::getUser(),'media','paths','')); - if(array_search($path,$paths)===false){ - $paths[]=$path; - OC_Preferences::setValue(OC_User::getUser(),'media','paths',implode(PATH_SEPARATOR,$paths)); - } - } echo OC_MEDIA_SCANNER::scanFolder($path); OC_DB::commit(); flush(); diff --git a/apps/media/appinfo/app.php b/apps/media/appinfo/app.php index 20c58689f09..fde005fe745 100644 --- a/apps/media/appinfo/app.php +++ b/apps/media/appinfo/app.php @@ -27,7 +27,6 @@ OC_Util::addScript('media','loader'); OC_App::register( array( 'order' => 3, 'id' => 'media', 'name' => 'Media' )); OC_App::addNavigationEntry( array( 'id' => 'media_index', 'order' => 2, 'href' => OC_Helper::linkTo( 'media', 'index.php' ), 'icon' => OC_Helper::imagePath( 'media', 'media.png' ), 'name' => 'Media' )); -OC_App::addSettingsPage( array( 'id' => 'media_settings', 'order' => 5, 'href' => OC_Helper::linkTo( 'media', 'settings.php' ), 'name' => 'Media', 'icon' => OC_Helper::imagePath( 'media', 'media.png' ))); // add subnavigations $entry = array( diff --git a/apps/media/settings.php b/apps/media/settings.php deleted file mode 100644 index 0563bc38fb3..00000000000 --- a/apps/media/settings.php +++ /dev/null @@ -1,52 +0,0 @@ -. -* -*/ - - -require_once('../../lib/base.php'); - -if( !OC_User::isLoggedIn()){ - header( "Location: ".OC_Helper::linkTo( "index.php" )); - exit(); -} - -require( 'lib_collection.php' ); - -OC_Util::addStyle('media','style'); -OC_Util::addScript('media','settings'); - -OC_App::setActiveNavigationEntry( 'media_settings' ); - -$folderNames=explode(PATH_SEPARATOR,OC_Preferences::getValue($_SESSION['user_id'],'media','paths','')); -$folders=array(); -foreach($folderNames as $folder){ - if($folder){ - $folders[]=array('name'=>$folder,'songs'=>OC_MEDIA_COLLECTION::getSongCountByPath($folder)); - } -} - -$tmpl = new OC_Template( 'media', 'settings', 'admin' ); -$tmpl->assign('folders',$folders); -$tmpl->assign('autoupdate',OC_Preferences::getValue($_SESSION['user_id'],'media','autoupdate',false)); -$tmpl->printPage(); -?> - From 02ebc4879a1a6fe1b400d668a4e6b5eebfcdd22c Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 2 Aug 2011 04:27:11 +0200 Subject: [PATCH 12/14] rename media to music in the navigation --- apps/media/appinfo/app.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/media/appinfo/app.php b/apps/media/appinfo/app.php index fde005fe745..4cdb36d4504 100644 --- a/apps/media/appinfo/app.php +++ b/apps/media/appinfo/app.php @@ -26,7 +26,7 @@ OC_Util::addScript('media','loader'); OC_App::register( array( 'order' => 3, 'id' => 'media', 'name' => 'Media' )); -OC_App::addNavigationEntry( array( 'id' => 'media_index', 'order' => 2, 'href' => OC_Helper::linkTo( 'media', 'index.php' ), 'icon' => OC_Helper::imagePath( 'media', 'media.png' ), 'name' => 'Media' )); +OC_App::addNavigationEntry( array( 'id' => 'media_index', 'order' => 2, 'href' => OC_Helper::linkTo( 'media', 'index.php' ), 'icon' => OC_Helper::imagePath( 'media', 'media.png' ), 'name' => 'Music' )); // add subnavigations $entry = array( From 900adb35d8a712809c6ed36f2a9b9b26285bdb7f Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 2 Aug 2011 04:43:08 +0200 Subject: [PATCH 13/14] make the progres bar for scanning always go to the full 100% --- apps/media/js/scanner.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/apps/media/js/scanner.js b/apps/media/js/scanner.js index e3867580bdb..de67c7c9931 100644 --- a/apps/media/js/scanner.js +++ b/apps/media/js/scanner.js @@ -1,6 +1,7 @@ Scanner={ songsFound:0, songsScanned:0, + songsChecked:0, startTime:null, endTime:null, stopScanning:false, @@ -18,6 +19,7 @@ Scanner={ scanFile:function(path,ready){ path=encodeURIComponent(path); $.getJSON(OC.linkTo('media','ajax/api.php')+'?action=get_path_info&path='+path,function(song){ + Scanner.songsChecked++; if(ready){ ready(song); } @@ -25,7 +27,7 @@ Scanner={ var artistId=song.song_artist; Scanner.songsScanned++; $('#scan span.songCount').text(Scanner.songsScanned); - var progress=(Scanner.songsScanned/Scanner.songsFound)*100; + var progress=(Scanner.songsChecked/Scanner.songsFound)*100; $('#scanprogressbar').progressbar('value',progress) Collection.addSong(song); } @@ -35,6 +37,8 @@ Scanner={ $('#scanprogressbar').progressbar({ value:0, }); + Scanner.songsChecked=0; + Scanner.songsScanned=0; Scanner.startTime=new Date().getTime()/1000; Scanner.findSongs(function(songs){ Scanner.songs=songs; From 957b9e8b8416377da7c25c0dc31e7b18c644cb6a Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 2 Aug 2011 17:02:27 +0200 Subject: [PATCH 14/14] send last modified header for media --- apps/media/ajax/api.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/apps/media/ajax/api.php b/apps/media/ajax/api.php index 8fcabbf840e..6014e4976c0 100644 --- a/apps/media/ajax/api.php +++ b/apps/media/ajax/api.php @@ -125,11 +125,19 @@ if($arguments['action']){ OC_MEDIA_COLLECTION::registerPlay($songId); header('Content-Type:'.$ftype); + // calc an offset of 24 hours + $offset = 3600 * 24; + // calc the string in GMT not localtime and add the offset + $expire = "Expires: " . gmdate("D, d M Y H:i:s", time() + $offset) . " GMT"; + //output the HTTP header + Header($expire); header('Expires: 0'); - header('Cache-Control: must-revalidate, post-check=0, pre-check=0'); + header('Cache-Control: max-age=3600, must-revalidate'); header('Pragma: public'); header('Accept-Ranges: bytes'); header('Content-Length: '.OC_Filesystem::filesize($arguments['path'])); + $gmt_mtime = gmdate('D, d M Y H:i:s', OC_Filesystem::filemtime($arguments['path']) ) . ' GMT'; + header("Last-Modified: " . $gmt_mtime ); OC_Filesystem::readfile($arguments['path']); exit;
+
Loading Collection...
@@ -7,4 +13,5 @@