upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-09 00:32:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 35

Merge pull request #54701 from nextcloud/backport/54690/stable30

Browse source 
[stable30] fix(TaskProcessingApiController): Don't allow anonymous access anymore
This commit is contained in:
Joas Schilling 2025-08-29 10:46:50 +02:00 committed by GitHub
commit 7c734a184d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
core/Controller/TaskProcessingApiController.php
View file

@ -13,11 +13,9 @@ namespace OC\Core\Controller;
use OC\Core\ResponseDefinitions;
use OC\Files\SimpleFS\SimpleFile;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\Attribute\AnonRateLimit;
use OCP\AppFramework\Http\Attribute\ApiRoute;
use OCP\AppFramework\Http\Attribute\ExAppRequired;
use OCP\AppFramework\Http\Attribute\NoAdminRequired;
use OCP\AppFramework\Http\Attribute\PublicPage;
use OCP\AppFramework\Http\Attribute\UserRateLimit;
use OCP\AppFramework\Http\DataDownloadResponse;
use OCP\AppFramework\Http\DataResponse;
@ -64,7 +62,7 @@ class TaskProcessingApiController extends \OCP\AppFramework\OCSController {
*
* 200: Task types returned
*/
#[PublicPage]
#[NoAdminRequired]
#[ApiRoute(verb: 'GET', url: '/tasktypes', root: '/taskprocessing')]
public function taskTypes(): DataResponse {
$taskTypes = array_map(function (array $tt) {
@ -115,9 +113,8 @@ class TaskProcessingApiController extends \OCP\AppFramework\OCSController {
* 412: Scheduling task is not possible
* 401: Cannot schedule task because it references files in its input that the user doesn't have access to
*/
#[PublicPage]
#[UserRateLimit(limit: 20, period: 120)]
#[AnonRateLimit(limit: 5, period: 120)]
#[NoAdminRequired]
#[ApiRoute(verb: 'POST', url: '/schedule', root: '/taskprocessing')]
public function schedule(
array $input, string $type, string $appId, string $customId = '',
@ -158,7 +155,7 @@ class TaskProcessingApiController extends \OCP\AppFramework\OCSController {
* 200: Task returned
* 404: Task not found
*/
#[PublicPage]
#[NoAdminRequired]
#[ApiRoute(verb: 'GET', url: '/task/{id}', root: '/taskprocessing')]
public function getTask(int $id): DataResponse {
try {

3
core/openapi-full.json
View file

@ -3837,7 +3837,6 @@
"task_processing_api"
],
"security": [
{},
{
"bearer_auth": []
},
@ -3910,7 +3909,6 @@
"task_processing_api"
],
"security": [
{},
{
"bearer_auth": []
},
@ -4180,7 +4178,6 @@
"task_processing_api"
],
"security": [
{},
{
"bearer_auth": []
},

3
core/openapi.json
View file

@ -3837,7 +3837,6 @@
"task_processing_api"
],
"security": [
{},
{
"bearer_auth": []
},
@ -3910,7 +3909,6 @@
"task_processing_api"
],
"security": [
{},
{
"bearer_auth": []
},
@ -4180,7 +4178,6 @@
"task_processing_api"
],
"security": [
{},
{
"bearer_auth": []
},