From 776c103c3633c62daef85342a0c90b20e6cf7b4b Mon Sep 17 00:00:00 2001
From: Louis Chemineau <louis@chmn.me>
Date: Tue, 1 Apr 2025 15:19:43 +0200
Subject: [PATCH] fix(files_reminder): Replace error log by setup check

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 .../lib/AppInfo/Application.php               |  2 +
 .../LoadAdditionalScriptsListener.php         |  1 -
 .../lib/SetupChecks/NeedNotificationsApp.php  | 37 +++++++++++++++++++
 3 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 apps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php

diff --git a/apps/files_reminders/lib/AppInfo/Application.php b/apps/files_reminders/lib/AppInfo/Application.php
index f0a3cc0f6f5..0ad503264d2 100644
--- a/apps/files_reminders/lib/AppInfo/Application.php
+++ b/apps/files_reminders/lib/AppInfo/Application.php
@@ -42,5 +42,7 @@ class Application extends App implements IBootstrap {
 		$context->registerEventListener(UserDeletedEvent::class, UserDeletedListener::class);
 
 		$context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalScriptsListener::class);
+
+		$context->registerSetupCheck(NeedNotificationsApp::class);
 	}
 }
diff --git a/apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php b/apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php
index 40aef1f9f69..13bf670f401 100644
--- a/apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php
+++ b/apps/files_reminders/lib/Listener/LoadAdditionalScriptsListener.php
@@ -31,7 +31,6 @@ class LoadAdditionalScriptsListener implements IEventListener {
 		}
 
 		if (!$this->appManager->isEnabledForUser('notifications')) {
-			$this->logger->info('Skipped registering the `files_reminders` app because the `notifications` app is disabled.', ['app' => 'files_reminders']);
 			return;
 		}
 
diff --git a/apps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php b/apps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php
new file mode 100644
index 00000000000..2fc80094152
--- /dev/null
+++ b/apps/files_reminders/lib/SetupChecks/NeedNotificationsApp.php
@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\DAV\SetupChecks;
+
+use OCP\App\IAppManager;
+use OCP\SetupCheck\ISetupCheck;
+use OCP\SetupCheck\SetupResult;
+
+class NeedNotificationsApp implements ISetupCheck {
+	public function __construct(
+		private IAppManager $appManager,
+	) {
+	}
+
+	public function getName(): string {
+		return $this->l10n->t('Files reminder');
+	}
+
+	public function getCategory(): string {
+		return 'system';
+	}
+
+	public function run(): SetupResult {
+		if ($this->appManager->isInstalled('notifications')) {
+			return SetupResult::success($this->l10n->t('This files_reminder can work properly.'));
+		} else {
+			return SetupResult::warning($this->l10n->t('The files_reminder app needs the notification app to work properly. You should either enable notifications or disable files_reminder.'));
+		}
+	}
+}