upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-09 08:44:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Merge pull request #23696 from nextcloud/fix/noid/fix-share-download-error-message

Browse source 
Return correct error message on share download without read permission
This commit is contained in:
Roeland Jago Douma 2020-10-26 19:42:54 +01:00 committed by GitHub
commit 7570daf123
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/files_sharing/lib/Controller/ShareController.php
View file

@ -556,7 +556,7 @@ class ShareController extends AuthPublicShareController {
$share = $this->shareManager->getShareByToken($token);
if (!($share->getPermissions() & \OCP\Constants::PERMISSION_READ)) {
return new \OCP\AppFramework\Http\DataResponse('Share is read-only');
return new \OCP\AppFramework\Http\DataResponse('Share has no read permission');
}
$files_list = null;

2
apps/files_sharing/tests/Controller/ShareControllerTest.php
View file

@ -840,7 +840,7 @@ class ShareControllerTest extends \Test\TestCase {
// Test with a password protected share and no authentication
$response = $this->shareController->downloadShare('validtoken');
$expectedResponse = new DataResponse('Share is read-only');
$expectedResponse = new DataResponse('Share has no read permission');
$this->assertEquals($expectedResponse, $response);
}