upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-22 23:03:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 78

perf: cache root cache entries for external storage in MountCacheService

Browse source 
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2025-12-18 16:55:10 +01:00
parent d64f7eb939
commit 73e84f9bf5
No known key found for this signature in database
GPG key ID: 42B69D8A64526EFB
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
apps/files_external/lib/Service/MountCacheService.php
View file

@ -15,6 +15,7 @@ use OCA\Files_External\Event\StorageCreatedEvent;
use OCA\Files_External\Event\StorageDeletedEvent;
use OCA\Files_External\Event\StorageUpdatedEvent;
use OCA\Files_External\Lib\StorageConfig;
use OCP\Cache\CappedMemoryCache;
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\Event as T;
use OCP\EventDispatcher\IEventListener;
@ -35,6 +36,8 @@ use OCP\User\Events\UserCreatedEvent;
* @template-implements IEventListener<StorageCreatedEvent|StorageDeletedEvent|StorageUpdatedEvent|BeforeGroupDeletedEvent|UserCreatedEvent|UserAddedEvent|UserRemovedEvent|Event>
*/
class MountCacheService implements IEventListener {
private CappedMemoryCache $storageRootCache;
public function __construct(
private readonly IUserMountCache $userMountCache,
private readonly ConfigAdapter $configAdapter,
@ -42,6 +45,7 @@ class MountCacheService implements IEventListener {
private readonly IGroupManager $groupManager,
private readonly GlobalStoragesService $storagesService,
) {
$this->storageRootCache = new CappedMemoryCache();
}
public function handle(Event $event): void {
@ -129,11 +133,16 @@ class MountCacheService implements IEventListener {
}
private function getCacheEntryForRoot(IUser $user, StorageConfig $storage): ICacheEntry {
// todo: reuse these between users when possible
$storage = $this->configAdapter->constructStorageForUser($user, $storage);
if ($cachedEntry = $this->storageRootCache->get($storage->getId())) {
return $cachedEntry;
}
$cache = $storage->getCache();
$entry = $cache->get('');
if ($entry) {
$this->storageRootCache->set($storage->getId(), $entry);
return $entry;
}
@ -157,7 +166,9 @@ class MountCacheService implements IEventListener {
];
$data['fileid'] = $cache->insert('', $data);
return new CacheEntry($data);
$entry = new CacheEntry($data);
$this->storageRootCache->set($storage->getId(), $entry);
return $entry;
}
private function registerForUser(IUser $user, StorageConfig $storage): void {