upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

Merge pull request #52968 from nextcloud/backport/52963/stable30

Browse source 
[stable30] fix(files_versions): Log error instead of crashing when event listeners get called on non-existing files
This commit is contained in:
Andy Scherzinger 2025-05-25 16:44:55 +02:00 committed by GitHub
commit 6d32c682ed
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 43 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
apps/files_versions/lib/Listener/FileEventsListener.php
View file

@ -124,6 +124,22 @@ class FileEventsListener implements IEventListener {
}
public function touch_hook(Node $node): void {
// Do not handle folders.
if ($node instanceof Folder) {
return;
}
if ($node instanceof NonExistingFile) {
$this->logger->error(
'Failed to create or update version for {path}, node does not exist',
[
'path' => $node->getPath(),
]
);
return;
}
$previousNode = $this->nodesTouched[$node->getId()] ?? null;
if ($previousNode === null) {
@ -151,7 +167,22 @@ class FileEventsListener implements IEventListener {
public function created(Node $node): void {
// Do not handle folders.
if ($node instanceof File && $this->versionManager instanceof INeedSyncVersionBackend) {
if (!($node instanceof File)) {
return;
}
if ($node instanceof NonExistingFile) {
$this->logger->error(
'Failed to create version for {path}, node does not exist',
[
'path' => $node->getPath(),
]
);
return;
}
if ($this->versionManager instanceof INeedSyncVersionBackend) {
$this->versionManager->createVersionEntity($node);
}
}
@ -189,6 +220,17 @@ class FileEventsListener implements IEventListener {
return;
}
if ($node instanceof NonExistingFile) {
$this->logger->error(
'Failed to create or update version for {path}, node does not exist',
[
'path' => $node->getPath(),
]
);
return;
}
$writeHookInfo = $this->writeHookInfo[$node->getId()] ?? null;
if ($writeHookInfo === null) {