From 6a1501a7d62ff8aca432afb2d9b8456063f6aa20 Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Mon, 20 Oct 2025 11:07:50 +0200 Subject: [PATCH] fix: address review comments Signed-off-by: Marcel Klehr --- lib/private/TaskProcessing/Db/TaskMapper.php | 2 +- lib/private/TaskProcessing/Manager.php | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/private/TaskProcessing/Db/TaskMapper.php b/lib/private/TaskProcessing/Db/TaskMapper.php index f9a33081a76..f62bb41be3b 100644 --- a/lib/private/TaskProcessing/Db/TaskMapper.php +++ b/lib/private/TaskProcessing/Db/TaskMapper.php @@ -270,7 +270,7 @@ class TaskMapper extends QBMapper { */ public function hasRunningTasksForTaskType(string $getTaskTypeId): bool { $qb = $this->db->getQueryBuilder(); - $qb->select(Task::$columns) + $qb->select('id') ->from($this->tableName); $qb->where($qb->expr()->eq('type', $qb->createNamedParameter($getTaskTypeId))); $qb->andWhere($qb->expr()->eq('status', $qb->createNamedParameter(\OCP\TaskProcessing\Task::STATUS_RUNNING, IQueryBuilder::PARAM_INT))); diff --git a/lib/private/TaskProcessing/Manager.php b/lib/private/TaskProcessing/Manager.php index e80935212d9..ccec65c6fb8 100644 --- a/lib/private/TaskProcessing/Manager.php +++ b/lib/private/TaskProcessing/Manager.php @@ -985,6 +985,8 @@ class Manager implements IManager { } } catch (Exception $e) { $this->logger->error('Failed to check DB for running tasks after a task was scheduled for a triggerable provider. Not triggering the provider.', ['exception' => $e]); + } catch (\Throwable $e) { + $this->logger->error('Failed to trigger the provider after scheduling a task.', ['exception' => $e]); } } }