upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 27

fix(IShareProvider): Add missing getChildren method to the interface

Browse source 
Signed-off-by: provokateurin <kate@provokateurin.de>
This commit is contained in:
provokateurin 2025-07-22 13:02:55 +02:00
parent 8bc5edf15f
commit 665a38573c
No known key found for this signature in database
6 changed files with 10 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
apps/federatedfilesharing/lib/FederatedShareProvider.php
View file

@ -431,13 +431,7 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl
return $share;
}
/**
* Get all children of this share
*
* @param IShare $parent
* @return IShare[]
*/
public function getChildren(IShare $parent) {
public function getChildren(IShare $parent): array {
$children = [];
$qb = $this->dbConnection->getQueryBuilder();

5
apps/sharebymail/lib/ShareByMailProvider.php
View file

@ -637,11 +637,6 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
return $token;
}
/**
* Get all children of this share
*
* @return IShare[]
*/
public function getChildren(IShare $parent): array {
$children = [];

3
build/psalm-baseline.xml
View file

@ -4261,9 +4261,6 @@
<UndefinedClass>
<code><![CDATA[\OCA\Circles\Api\v1\Circles]]></code>
</UndefinedClass>
<UndefinedInterfaceMethod>
<code><![CDATA[getChildren]]></code>
</UndefinedInterfaceMethod>
</file>
<file src="lib/private/Share20/ProviderFactory.php">
<InvalidReturnStatement>

9
lib/private/Share20/DefaultShareProvider.php
View file

@ -358,14 +358,7 @@ class DefaultShareProvider implements IShareProviderWithNotification, IShareProv
return $share;
}
/**
* Get all children of this share
* FIXME: remove once https://github.com/owncloud/core/pull/21660 is in
*
* @param \OCP\Share\IShare $parent
* @return \OCP\Share\IShare[]
*/
public function getChildren(\OCP\Share\IShare $parent) {
public function getChildren(IShare $parent): array {
$children = [];
$qb = $this->dbConn->getQueryBuilder();

1
lib/private/Share20/Manager.php
View file

@ -1008,7 +1008,6 @@ class Manager implements IManager {
/**
* Delete all the children of this share
* FIXME: remove once https://github.com/owncloud/core/pull/21660 is in
*
* @param IShare $share
* @return IShare[] List of deleted shares

8
lib/public/Share/IShareProvider.php
View file

@ -208,4 +208,12 @@ interface IShareProvider {
* @since 18.0.0
*/
public function getAllShares(): iterable;
/**
* Get all children of this share
*
* @return IShare[]
* @since 9.0.0
*/
public function getChildren(IShare $parent);
}