From 652158a72c3f443c49cb8c4658ef69c05f811437 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=B4me=20Chilliet?= Date: Mon, 12 Sep 2022 17:25:37 +0200 Subject: [PATCH] Improve typing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Côme Chilliet --- lib/private/Tagging/TagMapper.php | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/private/Tagging/TagMapper.php b/lib/private/Tagging/TagMapper.php index 7609347967a..808fce2eeae 100644 --- a/lib/private/Tagging/TagMapper.php +++ b/lib/private/Tagging/TagMapper.php @@ -46,15 +46,11 @@ class TagMapper extends QBMapper { /** * Load tags from the database. * - * @param array|string $owners The user(s) whose tags we are going to load. + * @param array $owners The user(s) whose tags we are going to load. * @param string $type The type of item for which we are loading tags. * @return array An array of Tag objects. */ - public function loadTags($owners, string $type): array { - if (!is_array($owners)) { - $owners = [$owners]; - } - + public function loadTags(array $owners, string $type): array { $qb = $this->db->getQueryBuilder(); $qb->select(['id', 'uid', 'type', 'category']) ->from($this->getTableName()) @@ -68,9 +64,8 @@ class TagMapper extends QBMapper { * Check if a given Tag object already exists in the database. * * @param Tag $tag The tag to look for in the database. - * @return bool */ - public function tagExists($tag) { + public function tagExists(Tag $tag): bool { $qb = $this->db->getQueryBuilder(); $qb->select(['id', 'uid', 'type', 'category']) ->from($this->getTableName())