upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

add better index for finding unindexed paths

Browse source 
for the following query 'SELECT "path" FROM "oc_filecache" WHERE ("storage" = $storage) AND ("size" < 0) ORDER BY "fileid" DESC LIMIT 1;'

currently the database will in some cases decide to priorize the sort by fileid over the filter when picking what index to use, resulting in a much slower query.

by creating an index that allows first sorting by fileid and also filter by storage and size this case will be greatly sped up

Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2021-10-07 16:11:49 +02:00
parent 6829449258
commit 6502dfae34
No known key found for this signature in database
GPG key ID: 42B69D8A64526EFB
3 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/Application.php
View file

@ -114,6 +114,10 @@ class Application extends App {
if (!$table->hasIndex('fs_size')) {
$subject->addHintForMissingSubject($table->getName(), 'fs_size');
}
if (!$table->hasIndex('fs_id_storage_size')) {
$subject->addHintForMissingSubject($table->getName(), 'fs_id_storage_size');
}
}
if ($schema->hasTable('twofactor_providers')) {

7
core/Command/Db/AddMissingIndices.php
View file

@ -144,6 +144,13 @@ class AddMissingIndices extends Command {
$updated = true;
$output->writeln('<info>Filecache table updated successfully.</info>');
}
if (!$table->hasIndex('fs_id_storage_size')) {
$output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
$table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size');
$this->connection->migrateToSchema($schema->getWrappedSchema());
$updated = true;
$output->writeln('<info>Filecache table updated successfully.</info>');
}
}
$output->writeln('<info>Check indices of the twofactor_providers table.</info>');

1
core/Migrations/Version13000Date20170718121200.php
View file

@ -261,6 +261,7 @@ class Version13000Date20170718121200 extends SimpleMigrationStep {
$table->addIndex(['storage', 'mimetype'], 'fs_storage_mimetype');
$table->addIndex(['storage', 'mimepart'], 'fs_storage_mimepart');
$table->addIndex(['storage', 'size', 'fileid'], 'fs_storage_size');
$table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size');
$table->addIndex(['mtime'], 'fs_mtime');
$table->addIndex(['size'], 'fs_size');
}