upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-09 00:32:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

fix(files): use type field instead of instanceof for Folder

Browse source 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This commit is contained in:
Git'Fellow 2026-05-19 23:09:04 +02:00 committed by nextcloud-command
parent 5ce47795c1
commit 5f894afb22
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
apps/files/src/components/FileEntryMixin.ts
View file

@ -497,7 +497,10 @@ export default defineComponent({
// canDrop already gates this branch on FileType.Folder, but the
// type system can't see that — narrow defensively so a future
// loosening of canDrop can't silently lie via the cast below.
if (!(this.source instanceof Folder)) {
// Use the `type` field rather than `instanceof Folder`: apps
// bundle their own copy of @nextcloud/files, so a Folder from
// an app would not be `instanceof` the server's Folder class.
if (this.source.type !== FileType.Folder) {
logger.error('onDrop: external drop target is not a Folder', { source: this.source })
this.dragover = false
return
@ -510,7 +513,7 @@ export default defineComponent({
: cachedContents
logger.debug('Start uploading dropped files', { target: this.source.path, fileTree })
await onDropExternalFiles(fileTree, this.source, contents)
await onDropExternalFiles(fileTree, this.source as Folder, contents)
this.dragover = false
return
}