upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-10 09:13:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54

fix: Update QuotaPlugin to handle 32-bit numeric lengths correctly

Browse source 
Signed-off-by: Josh <josh.t.richards@gmail.com>
This commit is contained in:
Josh 2025-09-26 13:40:59 -04:00 committed by GitHub
parent fbe5238d7f
commit 5f5bb77bf3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
apps/dav/lib/Connector/Sabre/QuotaPlugin.php
View file

@ -115,7 +115,7 @@ class QuotaPlugin extends \Sabre\DAV\ServerPlugin {
$destinationPath = $this->server->calculateUri($request->getUrl());
$collectionPath = $this->getPathForDestination($destinationPath);
} catch (\Exception $e) {
// Optionally log: error_log('Quota check failed during onCreateCollection: ' . $e->getMessage());
// Optionally log: e.g. ('Quota check failed during onCreateCollection: ' . $e->getMessage());
return true; // Quota cannot be checked, allow by default
}
if ($collectionPath) {
@ -275,9 +275,9 @@ class QuotaPlugin extends \Sabre\DAV\ServerPlugin {
* returns null.
*
* @internal
* @return int|null The largest valid content length, or null if none is found.
* @return int|float|null The largest valid content length, or null if none is found.
*/
public function getLength(): ?int {
public function getLength(): int|float|null {
$request = $this->server->httpRequest;
// Get headers as strings
@ -285,11 +285,11 @@ class QuotaPlugin extends \Sabre\DAV\ServerPlugin {
$contentLength = $request->getHeader('Content-Length');
$ocTotalLength = $request->getHeader('OC-Total-Length');
// Filter out non-numeric values, cast to int
// Filter out non-numeric values, use Util::numericToNumber for safe conversion
$lengths = array_filter([
is_numeric($expectedLength) ? (int)$expectedLength : null,
is_numeric($contentLength) ? (int)$contentLength : null,
is_numeric($ocTotalLength) ? (int)$ocTotalLength : null,
is_numeric($expectedLength) ? Util::numericToNumber($expectedLength) : null,
is_numeric($contentLength) ? Util::numericToNumber($contentLength) : null,
is_numeric($ocTotalLength) ? Util::numericToNumber($ocTotalLength) : null,
], fn ($v) => $v !== null);
// Return the largest valid length, or null if none