upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-08 16:26:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Ensure share has download permissions in F2V

Browse source 
Signed-off-by: Louis <louis@chmn.me>
This commit is contained in:
Louis 2023-11-23 12:29:17 +01:00 committed by backportbot-nextcloud[bot]
parent 9b752d977f
commit 5e8ee6e0d6
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
apps/files/src/actions/downloadAction.ts
View file

@ -41,6 +41,21 @@ const downloadNodes = function(dir: string, nodes: Node[]) {
triggerDownload(url)
}
// If the mount type is a share, ensure it got download permissions.
const isDownloadable = function(node: Node) {
if (node.attributes['mount-type'] !== 'shared') {
return true
}
const downloadAttribute = JSON.parse(node.attributes['share-attributes']).find(attribute => attribute.scope === 'permissions' && attribute.key === 'download')
if (downloadAttribute === undefined) {
return true
}
return downloadAttribute.enable
}
export const action = new FileAction({
id: 'download',
displayName: () => t('files', 'Download'),
@ -60,8 +75,7 @@ export const action = new FileAction({
}
return nodes
.map(node => node.permissions)
.every(permission => (permission & Permission.READ) !== 0)
.every(node => ((node.permissions & Permission.READ) !== 0) && isDownloadable(node))
},
async exec(node: Node, view: View, dir: string) {