upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

perf: remove unneeded sort when listing federated shares

Browse source 
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2026-05-08 18:12:13 +02:00 committed by backportbot[bot]
parent e43557ce8d
commit 5c7ac3ac4e
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
apps/federatedfilesharing/lib/FederatedShareProvider.php
View file

@ -406,8 +406,7 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl
$qb->select('*')
->from('share')
->where($qb->expr()->eq('parent', $qb->createNamedParameter($parent->getId())))
->andWhere($qb->expr()->in('share_type', $qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY)))
->orderBy('id');
->andWhere($qb->expr()->in('share_type', $qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY)));
$cursor = $qb->executeQuery();
while ($data = $cursor->fetchAssociative()) {
@ -539,8 +538,6 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl
$qb->andWhere($qb->expr()->eq('f.parent', $qb->createNamedParameter($node->getId())));
$qb->orderBy('id');
$cursor = $qb->executeQuery();
$shares = [];
while ($data = $cursor->fetchAssociative()) {
@ -595,7 +592,9 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl
}
$qb->setFirstResult($offset);
$qb->orderBy('id');
if ($offset !== 0 || $limit !== -1) {
$qb->orderBy('id');
}
$cursor = $qb->executeQuery();
$shares = [];
@ -672,8 +671,9 @@ class FederatedShareProvider implements IShareProvider, IShareProviderSupportsAl
$qb->select('*')
->from('share');
// Order by id
$qb->orderBy('id');
if ($offset !== 0 || $limit !== -1) {
$qb->orderBy('id');
}
// Set limit and offset
if ($limit !== -1) {