upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-11 09:42:09 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 40

fix(files_versions): Log error instead of crashing when event listeners get called on non-existing files

Browse source 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This commit is contained in:
Côme Chilliet 2025-05-19 17:33:17 +02:00 committed by Côme Chilliet
parent bd00b75b29
commit 5c0e8df427
1 changed files with 43 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
apps/files_versions/lib/Listener/FileEventsListener.php
View file

@ -125,6 +125,22 @@ class FileEventsListener implements IEventListener {
}
public function touch_hook(Node $node): void {
// Do not handle folders.
if ($node instanceof Folder) {
return;
}
if ($node instanceof NonExistingFile) {
$this->logger->error(
'Failed to create or update version for {path}, node does not exist',
[
'path' => $node->getPath(),
]
);
return;
}
$previousNode = $this->nodesTouched[$node->getId()] ?? null;
if ($previousNode === null) {
@ -152,7 +168,22 @@ class FileEventsListener implements IEventListener {
public function created(Node $node): void {
// Do not handle folders.
if ($node instanceof File && $this->versionManager instanceof INeedSyncVersionBackend) {
if (!($node instanceof File)) {
return;
}
if ($node instanceof NonExistingFile) {
$this->logger->error(
'Failed to create version for {path}, node does not exist',
[
'path' => $node->getPath(),
]
);
return;
}
if ($this->versionManager instanceof INeedSyncVersionBackend) {
$this->versionManager->createVersionEntity($node);
}
}
@ -190,6 +221,17 @@ class FileEventsListener implements IEventListener {
return;
}
if ($node instanceof NonExistingFile) {
$this->logger->error(
'Failed to create or update version for {path}, node does not exist',
[
'path' => $node->getPath(),
]
);
return;
}
$writeHookInfo = $this->writeHookInfo[$node->getId()] ?? null;
if ($writeHookInfo === null) {