upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-09 08:44:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Merge pull request #40103 from nextcloud/enh/enable-caldav-push-notifications-by-default

Browse source 
Enable caldav push notifications by default
This commit is contained in:
Hamza 2023-09-13 10:50:00 +02:00 committed by GitHub
commit 4f0a151eb4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php
View file

@ -82,7 +82,7 @@ class PushProvider extends AbstractProvider {
?string $calendarDisplayName,
array $principalEmailAddresses,
array $users = []):void {
if ($this->config->getAppValue('dav', 'sendEventRemindersPush', 'no') !== 'yes') {
if ($this->config->getAppValue('dav', 'sendEventRemindersPush', 'yes') !== 'yes') {
return;
}

2
apps/dav/lib/Settings/CalDAVSettings.php
View file

@ -47,7 +47,7 @@ class CalDAVSettings implements IDelegatedSettings {
'generateBirthdayCalendar' => 'yes',
'sendEventReminders' => 'yes',
'sendEventRemindersToSharedUsers' => 'yes',
'sendEventRemindersPush' => 'no',
'sendEventRemindersPush' => 'yes',
];
/**

4
apps/dav/tests/unit/CalDAV/Reminder/NotificationProvider/PushProviderTest.php
View file

@ -66,7 +66,7 @@ class PushProviderTest extends AbstractNotificationProviderTest {
public function testNotSend(): void {
$this->config->expects($this->once())
->method('getAppValue')
->with('dav', 'sendEventRemindersPush', 'no')
->with('dav', 'sendEventRemindersPush', 'yes')
->willReturn('no');
$this->manager->expects($this->never())
@ -92,7 +92,7 @@ class PushProviderTest extends AbstractNotificationProviderTest {
public function testSend(): void {
$this->config->expects($this->once())
->method('getAppValue')
->with('dav', 'sendEventRemindersPush', 'no')
->with('dav', 'sendEventRemindersPush', 'yes')
->willReturn('yes');
$user1 = $this->createMock(IUser::class);

2
apps/dav/tests/unit/Settings/CalDAVSettingsTest.php
View file

@ -62,7 +62,7 @@ class CalDAVSettingsTest extends TestCase {
['dav', 'generateBirthdayCalendar', 'yes'],
['dav', 'sendEventReminders', 'yes'],
['dav', 'sendEventRemindersToSharedUsers', 'yes'],
['dav', 'sendEventRemindersPush', 'no'],
['dav', 'sendEventRemindersPush', 'yes'],
)
->will($this->onConsecutiveCalls('yes', 'no', 'yes', 'yes', 'yes'));
$this->urlGenerator