From 51377570530fa299cf96cc60eaa26dbf14cf0872 Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Mon, 26 Feb 2024 16:57:30 +0100 Subject: [PATCH 1/9] fix(dav): Init ViewOnlyPlugin after auth Signed-off-by: Louis Chemineau --- apps/dav/lib/Server.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/dav/lib/Server.php b/apps/dav/lib/Server.php index 2bff8e7ebd6..3c7e0936735 100644 --- a/apps/dav/lib/Server.php +++ b/apps/dav/lib/Server.php @@ -241,11 +241,6 @@ class Server { $this->server->addPlugin(new FakeLockerPlugin()); } - // Allow view-only plugin for webdav requests - $this->server->addPlugin(new ViewOnlyPlugin( - \OC::$server->getUserFolder(), - )); - if (BrowserErrorPagePlugin::isBrowserRequest($request)) { $this->server->addPlugin(new BrowserErrorPagePlugin()); } @@ -255,6 +250,11 @@ class Server { // wait with registering these until auth is handled and the filesystem is setup $this->server->on('beforeMethod:*', function () use ($root, $lazySearchBackend, $logger) { + // Allow view-only plugin for webdav requests + $this->server->addPlugin(new ViewOnlyPlugin( + \OC::$server->getUserFolder(), + )); + // custom properties plugin must be the last one $userSession = \OC::$server->getUserSession(); $user = $userSession->getUser(); From 29a60ac7a903356dc0c68068a0dc49266a6a5305 Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Mon, 26 Feb 2024 18:01:14 +0100 Subject: [PATCH 2/9] chore(files_sharing): Remove legacy share permissions editor Signed-off-by: Louis Chemineau --- .../src/components/SharePermissionsEditor.vue | 290 ------------------ 1 file changed, 290 deletions(-) delete mode 100644 apps/files_sharing/src/components/SharePermissionsEditor.vue diff --git a/apps/files_sharing/src/components/SharePermissionsEditor.vue b/apps/files_sharing/src/components/SharePermissionsEditor.vue deleted file mode 100644 index cc1a150ecc1..00000000000 --- a/apps/files_sharing/src/components/SharePermissionsEditor.vue +++ /dev/null @@ -1,290 +0,0 @@ - - - - - - From bd88ecf534023c115307916eba8b74f0e9de0e4d Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Mon, 26 Feb 2024 18:53:22 +0100 Subject: [PATCH 3/9] test: Add test selector on sharing and versions components Signed-off-by: Louis Chemineau --- .../src/components/SharingEntry.vue | 1 + .../src/views/SharingDetailsTab.vue | 35 ++++++++++++++----- .../files_versions/src/components/Version.vue | 7 +++- 3 files changed, 34 insertions(+), 9 deletions(-) diff --git a/apps/files_sharing/src/components/SharingEntry.vue b/apps/files_sharing/src/components/SharingEntry.vue index 74bff87560a..6417ef0b6ea 100644 --- a/apps/files_sharing/src/components/SharingEntry.vue +++ b/apps/files_sharing/src/components/SharingEntry.vue @@ -46,6 +46,7 @@ @open-sharing-details="openShareDetailsForCustomSettings(share)" />