upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

Handle return code of streamCopy in WebDAV put

Browse source 
* throw a different exception if streamCopy failed
This commit is contained in:
Morris Jobke 2015-12-03 15:27:56 +01:00 committed by Vincent Petry
parent 94cf9e56b6
commit 43f5d8ab70
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
apps/dav/lib/connector/sabre/file.php
View file

@ -129,9 +129,17 @@ class File extends Node implements IFile {
// because we have no clue about the cause we can only throw back a 500/Internal Server Error
throw new Exception('Could not write file contents');
}
list($count,) = \OC_Helper::streamCopy($data, $target);
list($count, $result) = \OC_Helper::streamCopy($data, $target);
fclose($target);
if($result === false) {
$expected = -1;
if (isset($_SERVER['CONTENT_LENGTH'])) {
$expected = $_SERVER['CONTENT_LENGTH'];
}
throw new Exception('Error while copying file to target location (copied bytes: ' . $count . ', expected filesize: '. $expected .' )');
}
// if content length is sent by client:
// double check if the file was fully received
// compare expected and actual size