Merge pull request #56794 from nextcloud/feat/hide-developer-docs-conditionally

docs(settings): Removing the developerDocsUrl

apps/settings/lib/Controller/AppSettingsController.php

@@ -92,7 +92,6 @@ class AppSettingsController extends Controller {
 
 		$this->initialState->provideInitialState('appstoreEnabled', $this->config->getSystemValueBool('appstoreenabled', true));
 		$this->initialState->provideInitialState('appstoreBundles', $this->getBundles());
-		$this->initialState->provideInitialState('appstoreDeveloperDocs', $this->urlGenerator->linkToDocs('developer-manual'));
 		$this->initialState->provideInitialState('appstoreUpdateCount', count($this->getAppsWithUpdates()));
 
 		if ($this->appManager->isEnabledForAnyone('app_api')) {

apps/settings/src/views/AppStoreNavigation.vue

@@ -100,10 +100,6 @@
 				</NcAppNavigationItem>
 			</template>
 
-			<NcAppNavigationItem
-				id="app-developer-docs"
-				:name="t('settings', 'Developer documentation ↗')"
-				:href="developerDocsUrl" />
 		</template>
 	</NcAppNavigation>
 </template>
@@ -123,7 +119,6 @@ import APPSTORE_CATEGORY_ICONS from '../constants/AppstoreCategoryIcons.ts'
 import { useAppsStore } from '../store/apps-store.ts'
 
 const appstoreEnabled = loadState<boolean>('settings', 'appstoreEnabled', true)
-const developerDocsUrl = loadState<string>('settings', 'appstoreDeveloperDocs', '')
 
 const store = useAppsStore()
 const categories = computed(() => store.categories)

apps/settings/tests/Controller/AppSettingsControllerTest.php

@@ -170,7 +170,7 @@ class AppSettingsControllerTest extends TestCase {
 			->with('core_apps');
 
 		$this->initialState
-			->expects($this->exactly(4))
+			->expects($this->exactly(3))
 			->method('provideInitialState');
 
 		$policy = new ContentSecurityPolicy();
@@ -203,7 +203,7 @@ class AppSettingsControllerTest extends TestCase {
 			->with('core_apps');
 
 		$this->initialState
-			->expects($this->exactly(4))
+			->expects($this->exactly(3))
 			->method('provideInitialState');
 
 		$policy = new ContentSecurityPolicy();