From 5121c262e2c900de743637d206b18c2aeb43c25d Mon Sep 17 00:00:00 2001 From: Michael Gapczynski Date: Sun, 1 Jul 2012 11:31:01 -0400 Subject: [PATCH 1/6] Revert "bugfix for #1098 (assigning a group to a user, the group appears incrementally many times the more you assign it)" This reverts commit 265d7e50f55978a3bebfa077aa8552d5ea1b0c59. --- settings/js/users.js | 1 - 1 file changed, 1 deletion(-) diff --git a/settings/js/users.js b/settings/js/users.js index 6ee7fb04f07..b0ca3ad0e1a 100644 --- a/settings/js/users.js +++ b/settings/js/users.js @@ -213,6 +213,5 @@ $(document).ready(function(){ } } ); - location.reload(); }); }); From 949cab7ea17ed7e12b27886d46f45e541b138850 Mon Sep 17 00:00:00 2001 From: Michael Gapczynski Date: Fri, 29 Jun 2012 16:29:58 -0400 Subject: [PATCH 2/6] Add new group to other user's group select forms --- core/js/multiselect.js | 5 +++-- settings/js/users.js | 6 ++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/core/js/multiselect.js b/core/js/multiselect.js index db5afa637c9..ba89c1bb563 100644 --- a/core/js/multiselect.js +++ b/core/js/multiselect.js @@ -35,6 +35,7 @@ } button.click(function(event){ + var button=$(this); if(button.parent().children('ul').length>0){ button.parent().children('ul').slideUp(400,function(){ @@ -136,11 +137,11 @@ var option=$(''); + }) + }; element.multiSelect({ + createCallback:addGroup, createText:'add group', checked:checked, oncheck:checkHandeler, From dd7d34a40eca404240da6923115d375d041b1bd1 Mon Sep 17 00:00:00 2001 From: Michael Gapczynski Date: Fri, 29 Jun 2012 16:44:08 -0400 Subject: [PATCH 3/6] Prevent adding a duplicate to a multiselect --- core/js/multiselect.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/core/js/multiselect.js b/core/js/multiselect.js index ba89c1bb563..c4fd74b0475 100644 --- a/core/js/multiselect.js +++ b/core/js/multiselect.js @@ -129,13 +129,24 @@ if(event.keyCode == 13) { event.preventDefault(); event.stopPropagation(); + var value = $(this).val(); + var exists = false; + $.each(options,function(index, item) { + if ($(item).val() == value) { + exists = true; + return false; + } + }); + if (exists) { + return false; + } var li=$(this).parent(); $(this).remove(); li.text('+ '+settings.createText); li.before(createItem(this)); var select=button.parent().next(); var option=$('