diff --git a/apps/files/src/views/FilesList.vue b/apps/files/src/views/FilesList.vue index 825c71c19bd..7121e40c7db 100644 --- a/apps/files/src/views/FilesList.vue +++ b/apps/files/src/views/FilesList.vue @@ -434,6 +434,9 @@ export default defineComponent({ // TODO: preserve selection on browsing? this.selectionStore.reset() this.resetSearch() + if (window.OCA.Files.Sidebar?.close) { + window.OCA.Files.Sidebar.close() + } this.fetchContent() // Scroll to top, force virtual scroller to re-render diff --git a/apps/files/src/views/Sidebar.vue b/apps/files/src/views/Sidebar.vue index 9a28930f388..35afbb76432 100644 --- a/apps/files/src/views/Sidebar.vue +++ b/apps/files/src/views/Sidebar.vue @@ -110,7 +110,7 @@ import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus' import { File, Folder, formatFileSize } from '@nextcloud/files' import { encodePath } from '@nextcloud/paths' import { generateRemoteUrl, generateUrl } from '@nextcloud/router' -import { Type as ShareTypes } from '@nextcloud/sharing' +import { ShareTypes } from '@nextcloud/sharing' import { mdiStar, mdiStarOutline } from '@mdi/js' import axios from '@nextcloud/axios' import $ from 'jquery' diff --git a/apps/files_sharing/src/files_sharing_tab.js b/apps/files_sharing/src/files_sharing_tab.js index 602992320d1..09bedbc6398 100644 --- a/apps/files_sharing/src/files_sharing_tab.js +++ b/apps/files_sharing/src/files_sharing_tab.js @@ -73,12 +73,16 @@ window.addEventListener('DOMContentLoaded', function() { await TabInstance.update(fileInfo) TabInstance.$mount(el) }, + update(fileInfo) { TabInstance.update(fileInfo) }, + destroy() { - TabInstance.$destroy() - TabInstance = null + if (TabInstance) { + TabInstance.$destroy() + TabInstance = null + } }, })) } diff --git a/cypress.config.ts b/cypress.config.ts index d4fffa17a36..718d1d74507 100644 --- a/cypress.config.ts +++ b/cypress.config.ts @@ -46,6 +46,8 @@ export default defineConfig({ // Disable session isolation testIsolation: false, + requestTimeout: 30000, + // We've imported your old cypress plugins here. // You may want to clean this up later by importing these. async setupNodeEvents(on, config) { diff --git a/cypress/e2e/files/files-sidebar.cy.ts b/cypress/e2e/files/files-sidebar.cy.ts index 8e7dd699913..3d604530c76 100644 --- a/cypress/e2e/files/files-sidebar.cy.ts +++ b/cypress/e2e/files/files-sidebar.cy.ts @@ -22,6 +22,7 @@ import type { User } from '@nextcloud/cypress' import { getRowForFile, navigateToFolder, triggerActionForFile } from './FilesUtils' +import { assertNotExistOrNotVisible } from '../settings/usersUtils' describe('Files: Sidebar', { testIsolation: true }, () => { let user: User @@ -43,7 +44,10 @@ describe('Files: Sidebar', { testIsolation: true }, () => { triggerActionForFile('file', 'details') - cy.get('[data-cy-sidebar]').should('be.visible') + cy.get('[data-cy-sidebar]') + .should('be.visible') + .findByRole('heading', { name: 'file' }) + .should('be.visible') }) it('changes the current fileid', () => { @@ -56,10 +60,30 @@ describe('Files: Sidebar', { testIsolation: true }, () => { cy.url().should('contain', `apps/files/files/${fileId}`) }) - it('closes the sidebar on delete', () => { + it('changes the sidebar content on other file', () => { cy.visit('/apps/files') getRowForFile('file').should('be.visible') + triggerActionForFile('file', 'details') + + cy.get('[data-cy-sidebar]') + .should('be.visible') + .findByRole('heading', { name: 'file' }) + .should('be.visible') + + triggerActionForFile('folder', 'details') + cy.get('[data-cy-sidebar]') + .should('be.visible') + .findByRole('heading', { name: 'folder' }) + .should('be.visible') + }) + + it('closes the sidebar on navigation', () => { + cy.visit('/apps/files') + + getRowForFile('file').should('be.visible') + getRowForFile('folder').should('be.visible') + // open the sidebar triggerActionForFile('file', 'details') // validate it is open @@ -67,11 +91,33 @@ describe('Files: Sidebar', { testIsolation: true }, () => { // wait for the sidebar to be settled cy.wait(500) + // if we navigate to the folder + navigateToFolder('folder') + // the sidebar should not be visible anymore + cy.get('[data-cy-sidebar]') + .should(assertNotExistOrNotVisible) + }) + + it('closes the sidebar on delete', () => { + cy.intercept('DELETE', `**/remote.php/dav/files/${user.userId}/file`).as('deleteFile') + // visit the files app + cy.visit('/apps/files') + getRowForFile('file').should('be.visible') + // open the sidebar + triggerActionForFile('file', 'details') + // validate it is open + cy.get('[data-cy-sidebar]').should('be.visible') + // delete the file triggerActionForFile('file', 'delete') - cy.get('[data-cy-sidebar]').should('not.exist') + cy.wait('@deleteFile', { timeout: 10000 }) + // see the sidebar is closed + cy.get('[data-cy-sidebar]') + .should(assertNotExistOrNotVisible) }) it('changes the fileid on delete', () => { + cy.intercept('DELETE', `**/remote.php/dav/files/${user.userId}/folder/other`).as('deleteFile') + cy.uploadContent(user, new Blob([]), 'text/plain', '/folder/other').then((response) => { const otherFileId = Number.parseInt(response.headers['oc-fileid'] ?? '0') cy.login(user) @@ -90,6 +136,8 @@ describe('Files: Sidebar', { testIsolation: true }, () => { cy.wait(500) triggerActionForFile('other', 'delete') + cy.wait('@deleteFile') + cy.get('[data-cy-sidebar]').should('not.exist') // Ensure the URL is changed cy.url().should('not.contain', `apps/files/files/${otherFileId}`)