From 3d0e8a5002c36e08bb0c6a2d009d4535195be98b Mon Sep 17 00:00:00 2001 From: Carl Schwan Date: Fri, 11 Feb 2022 22:26:25 +0100 Subject: [PATCH] Don't redirect when loading files index page Currently we are redirecting from ?dir=/&fileid=2 to ?dir=/. This is an issue because we then need to load two pages with full file system setup and authentification instead of one and the assets won't start loading until the second page is delivered to the user. Additionally when loading ?dir=/, we then change the url back to ?dir=/&fileid=2 (without reload) so that the next time we load the page again we do the same thing again. Depending on the speed of the server and internet connection we can save 100ms to 400ms, improving the user experience. Signed-off-by: Carl Schwan --- apps/files/lib/Controller/ViewController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/files/lib/Controller/ViewController.php b/apps/files/lib/Controller/ViewController.php index fd84998769d..dbb852ffeb8 100644 --- a/apps/files/lib/Controller/ViewController.php +++ b/apps/files/lib/Controller/ViewController.php @@ -184,7 +184,7 @@ class ViewController extends Controller { * @throws NotFoundException */ public function index($dir = '', $view = '', $fileid = null, $fileNotFound = false, $openfile = null) { - if ($fileid !== null) { + if ($fileid !== null && $dir === '') { try { return $this->redirectToFile($fileid); } catch (NotFoundException $e) {