Merge pull request #56790 from nextcloud/refactor/password-confirm-attribute-getstrict

refactor: improve reflection attribute typing
2026-02-18 18:28:50 -05:00 · 2025-12-04 19:04:27 +01:00 · 2025-12-04 19:04:27 +01:00 · 3cdfe6dbfa
commit 3cdfe6dbfa
parent 189e1fcf22 8a581c230b
1 changed files with 2 additions and 0 deletions
--- a/lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
+++ b/lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
@ -24,6 +24,7 @@ use OCP\IUserSession;
 use OCP\Session\Exceptions\SessionNotAvailableException;
 use OCP\User\Backend\IPasswordConfirmationBackend;
 use Psr\Log\LoggerInterface;
+use ReflectionAttribute;
 use ReflectionMethod;

 class PasswordConfirmationMiddleware extends Middleware {
@ -115,6 +116,7 @@ class PasswordConfirmationMiddleware extends Middleware {
 	}

 	private function isPasswordConfirmationStrict(ReflectionMethod $reflectionMethod): bool {
+		/** @var ReflectionAttribute<PasswordConfirmationRequired>[] $attributes */
 		$attributes = $reflectionMethod->getAttributes(PasswordConfirmationRequired::class);
 		return !empty($attributes) && ($attributes[0]->newInstance()->getStrict());
 	}