upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-14 19:20:35 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

fix(dav): preserves the old hook-accessibility contract while still improving consistency

Browse source 
Signed-off-by: Josh <josh.t.richards@gmail.com>
This commit is contained in:
Josh 2026-05-17 10:44:58 -04:00 committed by GitHub
parent b7a850c3b7
commit 3ab1bd4549
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
apps/dav/lib/Connector/Sabre/File.php
View file

@ -345,8 +345,9 @@ class File extends Node implements IFile {
private function finalizeUpload(IStorage $storage, string $internalPath, bool $exists, ?View $view): void {
// Since we skipped the view for the final publish step, finalize the file
// state explicitly here: update cache/bookkeeping, persist metadata, emit
// post-write hooks, and only then downgrade the lock.
// state explicitly here: update cache/bookkeeping, persist metadata, then
// downgrade to a shared lock before emitting post-write hooks so listeners
// can still access the file.
$storage->getUpdater()->update($internalPath);
$fileInfoUpdate = [
@ -381,16 +382,17 @@ class File extends Node implements IFile {
$this->fileView->putFileInfo($this->path, $fileInfoUpdate);
$this->refreshInfo();
if ($view) {
$this->emitPostHooks($exists);
}
// Keep the exclusive lock until all bookkeeping and metadata updates are complete.
// Downgrade to shared lock before post hooks so legacy hook consumers can
// still access the file during post_write.
try {
$this->changeLock(ILockingProvider::LOCK_SHARED);
} catch (LockedException $e) {
throw new FileLocked($e->getMessage(), $e->getCode(), $e);
}
if ($view) {
$this->emitPostHooks($exists);
}
}
private function getPartFileBasePath($path) {