From 338ce725c70e17aa4d9fccce5a9e926098fa101c Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Wed, 7 Sep 2016 11:10:48 +0200 Subject: [PATCH] Only require CREATE permissions when the file does not exist yet --- apps/dav/lib/connector/sabre/objecttree.php | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/apps/dav/lib/connector/sabre/objecttree.php b/apps/dav/lib/connector/sabre/objecttree.php index 24ce4acdf22..adf55f81bb0 100644 --- a/apps/dav/lib/connector/sabre/objecttree.php +++ b/apps/dav/lib/connector/sabre/objecttree.php @@ -202,7 +202,11 @@ class ObjectTree extends \Sabre\DAV\Tree { $infoDestination = $this->fileView->getFileInfo(dirname($destinationPath)); $infoSource = $this->fileView->getFileInfo($sourcePath); - $destinationPermission = $infoDestination && $infoDestination->isUpdateable(); + if ($this->fileView->file_exists($destinationPath)) { + $destinationPermission = $infoDestination && $infoDestination->isUpdateable(); + } else { + $destinationPermission = $infoDestination && $infoDestination->isCreatable(); + } $sourcePermission = $infoSource && $infoSource->isDeletable(); if (!$destinationPermission || !$sourcePermission) { @@ -292,7 +296,12 @@ class ObjectTree extends \Sabre\DAV\Tree { } $info = $this->fileView->getFileInfo(dirname($destination)); - if ($info && !$info->isUpdateable()) { + if ($this->fileView->file_exists($destination)) { + $destinationPermission = $info && $info->isUpdateable(); + } else { + $destinationPermission = $info && $info->isCreatable(); + } + if (!$destinationPermission) { throw new Forbidden('No permissions to copy object.'); }