upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-20 22:00:39 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

test(settings): Correctly only return bool for Symfony Input::hasParameterOption calls

Browse source 
Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
Joas Schilling 2024-10-04 16:24:22 +02:00
parent e6cd1051da
commit 315e4658dd
No known key found for this signature in database
GPG key ID: F72FA5B49FFA96B0
1 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tests/Core/Command/User/SettingTest.php
View file

@ -193,7 +193,16 @@ class SettingTest extends TestCase {
->willReturnMap($options);
$this->consoleInput->expects($this->any())
->method('hasParameterOption')
->willReturnMap($parameterOptions);
->willReturnCallback(function (string|array $config, bool $default = false) use ($parameterOptions): bool {
foreach ($parameterOptions as $parameterOption) {
if ($config === $parameterOption[0]
// Check the default value if the maps has 3 entries
&& (!isset($parameterOption[2]) || $default === $parameterOption[1])) {
return end($parameterOption);
}
}
return false;
});
if ($user !== false) {
$this->userManager->expects($this->once())
@ -401,15 +410,16 @@ class SettingTest extends TestCase {
if ($defaultValue === null) {
$this->consoleInput->expects($this->atLeastOnce())
->method('hasParameterOption')
->willReturnMap([
['--default-value', false],
]);
->willReturn(false);
} else {
$this->consoleInput->expects($this->atLeastOnce())
->method('hasParameterOption')
->willReturnMap([
['--default-value', false, true],
]);
->willReturnCallback(function (string|array $config, bool $default = false): bool {
if ($config === '--default-value' && $default === false) {
return true;
}
return false;
});
$this->consoleInput->expects($this->once())
->method('getOption')
->with('default-value')