From 2528a46dc284a22381efb051367eecbcf5bb56b7 Mon Sep 17 00:00:00 2001 From: Carl Schwan Date: Sat, 19 Feb 2022 13:26:03 +0100 Subject: [PATCH] Fix more than 1000 entries in queries exception in CardDavBackend Signed-off-by: Carl Schwan --- apps/dav/lib/CardDAV/CardDavBackend.php | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/apps/dav/lib/CardDAV/CardDavBackend.php b/apps/dav/lib/CardDAV/CardDavBackend.php index 3e360fb2e41..98e85096b3b 100644 --- a/apps/dav/lib/CardDAV/CardDavBackend.php +++ b/apps/dav/lib/CardDAV/CardDavBackend.php @@ -1130,15 +1130,18 @@ class CardDavBackend implements BackendInterface, SyncSupport { return (int)$match['cardid']; }, $matches); - $query = $this->db->getQueryBuilder(); - $query->select('c.addressbookid', 'c.carddata', 'c.uri') - ->from($this->dbCardsTable, 'c') - ->where($query->expr()->in('c.id', $query->createNamedParameter($matches, IQueryBuilder::PARAM_INT_ARRAY))); + $cards = []; + foreach (array_chunk($matches, 1000) as $matche) { + $query = $this->db->getQueryBuilder(); + $query->select('c.addressbookid', 'c.carddata', 'c.uri') + ->from($this->dbCardsTable, 'c') + ->where($query->expr()->in('c.id', $query->createNamedParameter($matche, IQueryBuilder::PARAM_INT_ARRAY))); - $result = $query->execute(); - $cards = $result->fetchAll(); + $result = $query->execute(); + $cards = array_merge($cards, $result->fetchAll()); + $result->closeCursor(); + } - $result->closeCursor(); return array_map(function ($array) { $array['addressbookid'] = (int) $array['addressbookid'];