upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-17 02:49:55 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

Merge pull request #54584 from nextcloud/backport/54575/stable30

Browse source 
[stable30] fix: use appropriate user agent string when syncing Outlook calendar subscriptions
This commit is contained in:
Andy Scherzinger 2025-08-24 16:32:10 +02:00 committed by GitHub
commit 23facaacee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
apps/dav/lib/CalDAV/WebcalCaching/Connection.php
View file

@ -32,6 +32,16 @@ class Connection {
return null;
}
// ICS feeds hosted on O365 can return HTTP 500 when the UA string isn't satisfactory
// Ref https://github.com/nextcloud/calendar/issues/7234
$uaString = 'Nextcloud Webcal Service';
if (parse_url($url, PHP_URL_HOST) === 'outlook.office365.com') {
// The required format/values here are not documented.
// Instead, this string based on research.
// Ref https://github.com/bitfireAT/icsx5/discussions/654#discussioncomment-14158051
$uaString = 'Nextcloud (Linux) Chrome/66';
}
$allowLocalAccess = $this->config->getValueString('dav', 'webcalAllowLocalAccess', 'no');
$params = [
@ -39,7 +49,7 @@ class Connection {
'allow_local_address' => $allowLocalAccess === 'yes',
],
RequestOptions::HEADERS => [
'User-Agent' => 'Nextcloud Webcal Service',
'User-Agent' => $uaString,
'Accept' => 'text/calendar, application/calendar+json, application/calendar+xml',
],
];