upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54

fix(IStorage): Use false instead of bool intersection type to match implementations

Browse source 
Signed-off-by: provokateurin <kate@provokateurin.de>
This commit is contained in:
provokateurin 2024-09-19 15:47:26 +02:00
parent 7cdccd058f
commit 227609a954
No known key found for this signature in database
2 changed files with 10 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
build/psalm-baseline.xml
View file

@ -2066,11 +2066,6 @@
<code><![CDATA[remove]]></code>
</UndefinedMethod>
</file>
<file src="lib/private/Files/ObjectStore/ObjectStoreStorage.php">
<InvalidScalarArgument>
<code><![CDATA[$source]]></code>
</InvalidScalarArgument>
</file>
<file src="lib/private/Files/ObjectStore/S3ConnectionTrait.php">
<InternalClass>
<code><![CDATA[ClientResolver::_default_signature_provider()]]></code>
@ -2165,16 +2160,6 @@
<code><![CDATA[$size]]></code>
</InvalidScalarArgument>
</file>
<file src="lib/private/Files/Storage/Wrapper/Jail.php">
<InvalidReturnStatement>
<code><![CDATA[$this->getWrapperStorage()->filetype($this->getUnjailedPath($path))]]></code>
</InvalidReturnStatement>
<InvalidReturnType/>
</file>
<file src="lib/private/Files/Storage/Wrapper/Wrapper.php">
<InvalidReturnStatement/>
<InvalidReturnType/>
</file>
<file src="lib/private/Files/Stream/SeekableHttpStream.php">
<InvalidReturnType>
<code><![CDATA[stream_close]]></code>

20
lib/public/Files/Storage/IStorage.php
View file

@ -87,7 +87,7 @@ interface IStorage {
* only the following keys are required in the result: size and mtime
*
* @param string $path
* @return array|bool
* @return array|false
* @since 9.0.0
*/
public function stat($path);
@ -96,7 +96,7 @@ interface IStorage {
* see https://www.php.net/manual/en/function.filetype.php
*
* @param string $path
* @return string|bool
* @return string|false
* @since 9.0.0
*/
public function filetype($path);
@ -106,7 +106,7 @@ interface IStorage {
* The result for filesize when called on a folder is required to be 0
*
* @param string $path
* @return false|int|float
* @return int|float|false
* @since 9.0.0
*/
public function filesize($path);
@ -179,7 +179,7 @@ interface IStorage {
* see https://www.php.net/manual/en/function.filemtime.php
*
* @param string $path
* @return int|bool
* @return int|false
* @since 9.0.0
*/
public function filemtime($path);
@ -237,7 +237,7 @@ interface IStorage {
*
* @param string $path
* @param string $mode
* @return resource|bool
* @return resource|false
* @since 9.0.0
*/
public function fopen($path, $mode);
@ -247,7 +247,7 @@ interface IStorage {
* The mimetype for a folder is required to be "httpd/unix-directory"
*
* @param string $path
* @return string|bool
* @return string|false
* @since 9.0.0
*/
public function getMimeType($path);
@ -258,16 +258,16 @@ interface IStorage {
* @param string $type
* @param string $path
* @param bool $raw
* @return string|bool
* @return string|false
* @since 9.0.0
*/
public function hash($type, $path, $raw = false);
/**
* see https://www.php.net/manual/en/function.free_space.php
* see https://www.php.net/manual/en/function.disk-free-space.php
*
* @param string $path
* @return int|float|bool
* @return int|float|false
* @since 9.0.0
*/
public function free_space($path);
@ -345,7 +345,7 @@ interface IStorage {
* For now the returned array can hold the parameter url - in future more attributes might follow.
*
* @param string $path
* @return array|bool
* @return array|false
* @since 9.0.0
*/
public function getDirectDownload($path);