Merge pull request #56716 from nextcloud/fix/logger
Some checks are pending
CodeQL Advanced / Analyze (actions) (push) Waiting to run
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Waiting to run
Integration sqlite / integration-sqlite (master, 8.4, main, --tags ~@large files_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, capabilities_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, collaboration_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, comments_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, dav_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, federation_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, file_conversions) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, files_reminders) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, filesdrop_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, ldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, openldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, openldap_numerical_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, remoteapi_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, routing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, setup_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, sharees_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, sharing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, theming_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, 8.4, main, videoverification_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis (push) Waiting to run
Psalm static code analysis / static-code-analysis-security (push) Waiting to run
Psalm static code analysis / static-code-analysis-ocp (push) Waiting to run
Psalm static code analysis / static-code-analysis-ncu (push) Waiting to run

fix(logger): add back lost params for logger methods
This commit is contained in:
Joas Schilling 2025-11-27 15:54:43 +01:00 committed by GitHub
commit 1c7ed89855
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -15,6 +15,7 @@ use OCP\Log\IDataLogger;
use Psr\Log\InvalidArgumentException;
use Psr\Log\LoggerInterface;
use Psr\Log\LogLevel;
use Stringable;
use Throwable;
use function array_key_exists;
use function array_merge;
@ -27,14 +28,14 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
public static function logLevelToInt(string $level): int {
return match ($level) {
LogLevel::ALERT => ILogger::ERROR,
LogLevel::CRITICAL => ILogger::ERROR,
LogLevel::DEBUG => ILogger::DEBUG,
LogLevel::EMERGENCY => ILogger::FATAL,
LogLevel::ERROR => ILogger::ERROR,
LogLevel::INFO => ILogger::INFO,
LogLevel::NOTICE => ILogger::INFO,
LogLevel::ALERT,
LogLevel::ERROR,
LogLevel::CRITICAL => ILogger::ERROR,
LogLevel::WARNING => ILogger::WARN,
LogLevel::INFO,
LogLevel::NOTICE => ILogger::INFO,
LogLevel::DEBUG => ILogger::DEBUG,
default => throw new InvalidArgumentException('Unsupported custom log level'),
};
}
@ -50,10 +51,9 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
/**
* System is unusable.
*
* @param $message
* @param mixed[] $context
*/
public function emergency($message, array $context = []): void {
public function emergency(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::EMERGENCY, (string)$message, $context);
}
@ -63,10 +63,9 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
* Example: Entire website down, database unavailable, etc. This should
* trigger the SMS alerts and wake you up.
*
* @param $message
* @param mixed[] $context
*/
public function alert($message, array $context = []): void {
public function alert(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::ALERT, (string)$message, $context);
}
@ -75,10 +74,9 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
*
* Example: Application component unavailable, unexpected exception.
*
* @param $message
* @param mixed[] $context
*/
public function critical($message, array $context = []): void {
public function critical(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::CRITICAL, (string)$message, $context);
}
@ -86,10 +84,9 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
* Runtime errors that do not require immediate action but should typically
* be logged and monitored.
*
* @param $message
* @param mixed[] $context
*/
public function error($message, array $context = []): void {
public function error(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::ERROR, (string)$message, $context);
}
@ -99,20 +96,18 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
* Example: Use of deprecated APIs, poor use of an API, undesirable things
* that are not necessarily wrong.
*
* @param $message
* @param mixed[] $context
*/
public function warning($message, array $context = []): void {
public function warning(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::WARNING, (string)$message, $context);
}
/**
* Normal but significant events.
*
* @param $message
* @param mixed[] $context
*/
public function notice($message, array $context = []): void {
public function notice(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::NOTICE, (string)$message, $context);
}
@ -121,20 +116,18 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
*
* Example: User logs in, SQL logs.
*
* @param $message
* @param mixed[] $context
*/
public function info($message, array $context = []): void {
public function info(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::INFO, (string)$message, $context);
}
/**
* Detailed debug information.
*
* @param $message
* @param mixed[] $context
*/
public function debug($message, array $context = []): void {
public function debug(string|Stringable $message, array $context = []): void {
$this->log(LogLevel::DEBUG, (string)$message, $context);
}
@ -142,7 +135,6 @@ final class PsrLoggerAdapter implements LoggerInterface, IDataLogger {
* Logs with an arbitrary level.
*
* @param mixed $level
* @param $message
* @param mixed[] $context
*
* @throws InvalidArgumentException