From 181586123bd5123dcbc65e2f24188693b69de8c6 Mon Sep 17 00:00:00 2001
From: Elizabeth Danzberger <lizzy7128@tutanota.de>
Date: Fri, 31 Jan 2025 15:34:47 -0500
Subject: [PATCH] fix(template-filler): Hide template fields with unknown
 labels

Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
---
 apps/files/src/components/TemplateFiller.vue       | 14 +++++++++++---
 .../TemplateFiller/TemplateCheckboxField.vue       |  2 +-
 .../TemplateFiller/TemplateRichTextField.vue       |  2 +-
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/apps/files/src/components/TemplateFiller.vue b/apps/files/src/components/TemplateFiller.vue
index bd3c28d585f..9aa3617a3eb 100644
--- a/apps/files/src/components/TemplateFiller.vue
+++ b/apps/files/src/components/TemplateFiller.vue
@@ -4,13 +4,18 @@
 -->
 
 <template>
-	<NcModal>
+	<NcModal label-id="template-field-modal__label">
 		<div class="template-field-modal__content">
 			<form>
-				<h3>{{ t('files', 'Fill template fields') }}</h3>
+				<h3 id="template-field-modal__label">
+					{{ t('files', 'Fill template fields') }}
+				</h3>
 
 				<div v-for="field in fields" :key="field.index">
-					<component :is="getFieldComponent(field.type)" :field="field" @input="trackInput" />
+					<component :is="getFieldComponent(field.type)"
+						v-if="fieldHasLabel(field)"
+						:field="field"
+						@input="trackInput" />
 				</div>
 			</form>
 		</div>
@@ -80,6 +85,9 @@ export default defineComponent({
 
 			return `Template${fieldComponentType}Field`
 		},
+		fieldHasLabel(field) {
+			return field.name || field.alias
+		},
 		async submit() {
 			this.loading = true
 
diff --git a/apps/files/src/components/TemplateFiller/TemplateCheckboxField.vue b/apps/files/src/components/TemplateFiller/TemplateCheckboxField.vue
index 632944f1bab..d617fd93303 100644
--- a/apps/files/src/components/TemplateFiller/TemplateCheckboxField.vue
+++ b/apps/files/src/components/TemplateFiller/TemplateCheckboxField.vue
@@ -40,7 +40,7 @@ export default defineComponent({
 
 	computed: {
 		fieldLabel() {
-			const label = this.field.name ?? this.field.alias ?? 'Unknown field'
+			const label = this.field.name || this.field.alias
 
 			return label.charAt(0).toUpperCase() + label.slice(1)
 		},
diff --git a/apps/files/src/components/TemplateFiller/TemplateRichTextField.vue b/apps/files/src/components/TemplateFiller/TemplateRichTextField.vue
index 7246b2743d6..1a4518b304b 100644
--- a/apps/files/src/components/TemplateFiller/TemplateRichTextField.vue
+++ b/apps/files/src/components/TemplateFiller/TemplateRichTextField.vue
@@ -45,7 +45,7 @@ export default defineComponent({
 
 	computed: {
 		fieldLabel() {
-			const label = this.field.name ?? this.field.alias ?? 'Unknown field'
+			const label = this.field.name || this.field.alias
 
 			return (label.charAt(0).toUpperCase() + label.slice(1))
 		},