upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-09 00:32:29 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 35

fix(theming): read cachebuster as int in manifest endpoint

Browse source 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This commit is contained in:
Git'Fellow 2026-06-05 10:34:44 +02:00
parent ce3b3b7689
commit 17bbc56dab
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/theming/lib/Controller/ThemingController.php
View file

@ -457,7 +457,7 @@ class ThemingController extends Controller {
#[BruteForceProtection(action: 'manifest')]
#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
public function getManifest(string $app): JSONResponse {
$cacheBusterValue = $this->appConfig->getAppValueString('cachebuster', '0');
$cacheBusterValue = (string)$this->appConfig->getAppValueInt('cachebuster');
if ($app === 'core' || $app === 'settings') {
$name = $this->themingDefaults->getName();
$shortName = $this->themingDefaults->getName();

6
apps/theming/tests/Controller/ThemingControllerTest.php
View file

@ -734,9 +734,9 @@ class ThemingControllerTest extends TestCase {
public function testGetManifest(bool $standalone): void {
$this->appConfig
->expects($this->once())
->method('getAppValueString')
->with('cachebuster', '0')
->willReturn('0');
->method('getAppValueInt')
->with('cachebuster')
->willReturn(0);
$this->themingDefaults
->expects($this->any())
->method('getName')